feat(subs,gate): substantial integration#844
Merged
michael-0acf4 merged 6 commits intomainfrom Sep 23, 2024
Merged
Conversation
3 tasks
michael-0acf4
requested review from
Natoandro,
Yohe-Am,
j03-dev,
luckasRanarison and
zifeo
michael-0acf4
commented
Sep 10, 2024
michael-0acf4
commented
Sep 10, 2024
michael-0acf4
commented
Sep 10, 2024
michael-0acf4
commented
Sep 10, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #844 +/- ##
==========================================
+ Coverage 76.26% 77.25% +0.98%
==========================================
Files 145 147 +2
Lines 16796 17226 +430
Branches 1649 1701 +52
==========================================
+ Hits 12810 13308 +498
+ Misses 3967 3899 -68
Partials 19 19 ☔ View full report in Codecov by Sentry. |
michael-0acf4
changed the title
3 tasks
michael-0acf4
changed the title
michael-0acf4
force-pushed
the
substantial-integration
branch
from
7002b36 to
a1c48a5
Compare
Yohe-Am
previously approved these changes
Sep 17, 2024
Contributor
Yohe-Am
left a comment
Yohe-Am
left a comment
There was a problem hiding this comment.
Looking good. But as the complexity increases, we'll need to invest in even more massive test infra. A sound model can still have faulty implementations.
michael-0acf4
force-pushed
the
substantial-integration
branch
4 times, most recently
from
ee02244 to
6ea439f
Compare
michael-0acf4
force-pushed
the
substantial-integration
branch
3 times, most recently
from
6e86f56 to
196c769
Compare
Natoandro
approved these changes
Sep 23, 2024
michael-0acf4
added a commit
that referenced
this pull request
Sep 24, 2024
Continuation of #844 Note: There is currently no need for additional flags when running typegate, existing runs should be picked automatically as long as the typegraph owning the workflow is deployed. SubstantialRuntime will launch and start the agent, the later will attempt to 'pick' jobs on the backend and spawn workers if it can acquire it. Workflows are identified relative to their names for now, the content hash might be the way to go going forward, downside being that it will change even on smaller modifications (e.g. spaces, missing semicolons, ..). #### Migration notes None - [x] The change comes with new or modified tests - [ ] Hard-to-understand functions have explanatory comments - [ ] End-user documentation is updated to reflect the change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #818
SUBSTANTIAL_RELAUNCH_MSctx.sleep(..),ctx.ensure(..))Also removed Substantial syntactic sugar from the Deno/PythonRuntime SDKs as it might introduce confusion on the inner workings of the Typegate.
Migration notes
None