Skip to content

refactor(sdk)!: remove index based names#848

Merged
Natoandro merged 10 commits into
mainfrom
met-654-sdk-remove-index-based-titles
Sep 23, 2024
Merged

refactor(sdk)!: remove index based names#848
Natoandro merged 10 commits into
mainfrom
met-654-sdk-remove-index-based-titles

Conversation

@Yohe-Am
Copy link
Copy Markdown
Contributor

@Yohe-Am Yohe-Am commented Sep 18, 2024

  • Replace index based names for types by one that relies on type context in graph
  • Tests for type deduplication

Migration notes

TODO

  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@linear
Copy link
Copy Markdown

linear Bot commented Sep 18, 2024

@Yohe-Am Yohe-Am requested a review from Natoandro September 20, 2024 08:18
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.26%. Comparing base (c31e20c) to head (dbc3bbd).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #848      +/-   ##
==========================================
- Coverage   76.48%   76.26%   -0.23%     
==========================================
  Files         145      145              
  Lines       16796    16796              
  Branches     1654     1649       -5     
==========================================
- Hits        12847    12810      -37     
- Misses       3930     3967      +37     
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread src/typegraph/core/src/utils/postprocess/naming.rs
Comment thread src/common/src/typegraph/mod.rs
@Natoandro Natoandro merged commit 15c1afa into main Sep 23, 2024
@Natoandro Natoandro deleted the met-654-sdk-remove-index-based-titles branch September 23, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants