fix: improve name generation for prisma types#849
Merged
Conversation
Natoandro
force-pushed
the
met-657-prisma-generated-type-names
branch
from
172914a to
6b9e63a
Compare
Natoandro
requested review from
Yohe-Am,
j03-dev,
luckasRanarison,
michael-0acf4 and
zifeo
Yohe-Am
previously approved these changes
Sep 20, 2024
Contributor
Yohe-Am
left a comment
Yohe-Am
left a comment
There was a problem hiding this comment.
Just noticed, I'm actually using the snek case format for generated names in the other PR while the new names in this PR seem to be Pascal case. How should we proceed?
Contributor
Author
I will switch to snake case.... |
# Conflicts: # .ghjk/lock.json # ghjk.ts
michael-0acf4
previously approved these changes
Sep 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #849 +/- ##
=======================================
Coverage 77.04% 77.04%
=======================================
Files 147 147
Lines 17226 17226
Branches 1697 1697
=======================================
Hits 13271 13271
Misses 3936 3936
Partials 19 19 ☔ View full report in Codecov by Sentry. |
michael-0acf4
approved these changes
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solve MET-657
Migration notes
...