refactor!: Move as_id out of TypeNode#866
Merged
Conversation
TypeNodeTypeNode
Member
|
Very nice! |
74aabd6 to
4f4c544
Compare
Yohe-Am
previously approved these changes
Oct 11, 2024
Contributor
Yohe-Am
left a comment
There was a problem hiding this comment.
Great reduction of debt.
Contributor
|
I rec we release 0.5 after this is done. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #866 +/- ##
==========================================
+ Coverage 77.09% 77.11% +0.01%
==========================================
Files 149 149
Lines 17849 17843 -6
Branches 1730 1732 +2
==========================================
- Hits 13761 13759 -2
+ Misses 4065 4061 -4
Partials 23 23 ☔ View full report in Codecov by Sentry. |
michael-0acf4
approved these changes
Oct 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solve MET-684 and MET-471
ObjectTypeDatainstead of in the target type (as_id)id()method ont.integerandt.stringas_id,injectionandpolicyinTypeRef::attributeTypeRefTypeDefMigration notes
BREAKING CHANGE
from_parentinjections source shall be changed to the key in the parentt.structinstead of the type name.Checklist