-
Notifications
You must be signed in to change notification settings - Fork 14
feat(subs): child workflows + docs #867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #867 +/- ##
==========================================
+ Coverage 77.01% 77.09% +0.07%
==========================================
Files 149 149
Lines 17867 18129 +262
Branches 1737 1756 +19
==========================================
+ Hits 13761 13976 +215
- Misses 4083 4130 +47
Partials 23 23 ☔ View full report in Codecov by Sentry. |
f6e056b to
56afeb7
Compare
557efa7 to
63dae92
Compare
Yohe-Am
previously approved these changes
Oct 14, 2024
687f759 to
1554d7c
Compare
4648da3 to
d7f5461
Compare
e6d5b78 to
711a6f2
Compare
Yohe-Am
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for child workflows.
Solves MET-689 and MET-668.
Migration notes
Previously
This approach relied on workflow files being referenced in each materializer, but the constructs were too restrictive to support something like
mutation { results(name: "nameManuallyGiven") }.We now have instead