refactor: move injection data to t.func#871
Merged
Merged
Conversation
3 tasks
# Conflicts: # src/common/src/typegraph/validator/mod.rs # src/typegate/src/runtimes/typegraph.ts
Yohe-Am
approved these changes
Oct 18, 2024
# Conflicts: # .ghjk/lock.json # .pre-commit-config.yaml # ghjk.ts # src/typegate/src/runtimes/substantial.ts
michael-0acf4
left a comment
michael-0acf4
left a comment
Contributor
There was a problem hiding this comment.
That's a lot of changes! Good stuff.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #871 +/- ##
==========================================
- Coverage 77.20% 76.80% -0.41%
==========================================
Files 149 149
Lines 18103 18221 +118
Branches 1756 1768 +12
==========================================
+ Hits 13976 13994 +18
- Misses 4104 4204 +100
Partials 23 23 ☔ View full report in Codecov by Sentry. |
Yohe-Am
approved these changes
Oct 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ObjectTypeData(i.e.t.func)t.funcTypeNode(refactor: Removeruntimefield fromTypeNode#858)MaterializerDataorRuntimeDataTG_PORT=0); this will work withmeta devwith embedded typegate if you set the--gateoption with port0.Migration notes
...