Skip to content

fix: speculative fix for typegate_prisma_test.ts#898

Merged
Yohe-Am merged 3 commits into
mainfrom
met-716-flakey-testtypegate_prisma_testts
Nov 1, 2024
Merged

fix: speculative fix for typegate_prisma_test.ts#898
Yohe-Am merged 3 commits into
mainfrom
met-716-flakey-testtypegate_prisma_testts

Conversation

@Yohe-Am
Copy link
Copy Markdown
Contributor

@Yohe-Am Yohe-Am commented Oct 31, 2024

  • Assigns special schemas for each test that relies on the runtimes/prisma/prisma.py typegraph.
  • Bumps version tag to 0.5.0-rc4
  • Fixes issues in release pipeline
  • Disables all but the test-full job when the test pipeline is run with tmate enabled.

The flakeout of typegate_prisma_test.ts has proved difficult to recreate. Looking at the code and going from recent similar cases, I suspect it happens due to the old code reusing the same pg schema for multiple tests. Assigning special schemas for each tests should hopefully help.

Migration notes

N/A


  • The change comes with new or modified tests

@Yohe-Am Yohe-Am requested a review from Natoandro October 31, 2024 00:36
@linear
Copy link
Copy Markdown

linear Bot commented Oct 31, 2024

Signed-off-by: Yohe-Am <56622350+Yohe-Am@users.noreply.github.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.46%. Comparing base (0a27b94) to head (55bfe84).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #898      +/-   ##
==========================================
+ Coverage   76.77%   77.46%   +0.69%     
==========================================
  Files         149      149              
  Lines       18233    18244      +11     
  Branches     1768     1784      +16     
==========================================
+ Hits        13998    14133     +135     
+ Misses       4212     4088     -124     
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@Natoandro Natoandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different schema name is definitely the right solution...
Good job 💪

Comment thread tests/runtimes/typegate/__snapshots__/typegate_prisma_test.ts.snap
@Yohe-Am Yohe-Am merged commit 18a13d6 into main Nov 1, 2024
@Yohe-Am Yohe-Am deleted the met-716-flakey-testtypegate_prisma_testts branch November 1, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants