Fixes #350, makes source maps line up with the correct lines in DevTools #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s when viewed in DevTools
Contributor
Author
|
Thanks so much @Akryum! Do you mind please publishing a new version to Atmosphere? |
Collaborator
|
Will do soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one-line PR fixes #350, where the source maps are offset by the number of lines above the
<script>opening tag:(Line 14 is supposed to be highlighted, not line 21. And the brighter-colored line numbers should correspond with the lines where there is source code; picture them shifted up 8 lines each.)
Once this is merged in, not only will
debuggerstatements be highlighted on the proper line, but you can also just click on the line number in the gutter in DevTools to set a breakpoint on that line (you know, how it’s supposed to work). Fixesakryum:vue-coffeetoo.