After upgrading to 2.2.0, <input> tag 'readonly' attribute is not rendered

[jancurn]

Hi there, after I upgraded blaze@2.1.9 to blaze@2.2.0 in our Meteor app, the 'readonly' attributes on tag are no longer rendered. This only happens if the tag has some dynamically generated attributes, for example:

<input type="text" readonly value="{{todo.text}}">

This one works correctly:

<input type="text" readonly>

I replicated the problem also in "Todos" example app. I cloned the repo from https://github.com/meteor/todos, updated meteor and all packages to their latest versions and have the same problem (actually I tested the above code in Todos app). When I downgraded to blaze@2.1.9, readonly attribute is rendered (although not as boolean attribute like 'disabled', but that's another story). Strangely enough, other attributes like 'disabled' are rendered normally.

[mitar]

So this might be related to #102. @gcacars, could you take a look?

@jancurn: could you make a pull request with a test to Blaze to test for this case? Are we missing a test for this?

[jancurn]

re @mitar: I will try to add some test, although not sure when I find time for it :-/

[thearabbit]

I have the same problem

// Work fine for blaze 2.1.9, but now don't work
{{> afQuickField name='branchId' readonly=true}}

How to fix?

[gabe-cabral]

I done some tests with my project.

Template.login.helpers({
    attrs(){
        return {
            readonly: false
        };
    },

    test(){
        return false;
    }
});

<input class="form-control" type="text" name="username" {{attrs}} disabled="{{test}}" required>

Any helper like disabled (helper in attribute) works fine.
But nothing in attrs works correctly.
I think that Blaze do something different with dynamic attributes.
@mitar Could you help with this? Where in the code Blaze treat this.

I also test an input like jancurn said:
<input type="text" readonly value="{{todo.text}}">

For me works fine.

[thearabbit]

Thanks, but I use AutoForm so I can't use like this

Template.login.helpers({
    attrs(){
        return {
            readonly: false
        };
    },
});
--------
{{> afQuickField name='branchId' attrs}}

Could you help me?

[mitar]

@gcacars: Maybe here or here?

But where does your pull request interfere with that?

[thearabbit]

Now I downgrade to 2.1.9

[bluefangs]

@thearabbit - Could you please tell me how you downgraded to 2.1.9?

[thearabbit]

please look in

.meteor/
   versions

And then find the blaze@2.1.9

[jancurn]

hey guys, I wanted to write a test for this bug, but I wasn't able to find out how to run tests in this project...