Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Blaze: hidden html attribute does not work properly #52

Closed
gcacars opened this issue Aug 1, 2016 · 2 comments
Closed

[Bug] Blaze: hidden html attribute does not work properly #52

gcacars opened this issue Aug 1, 2016 · 2 comments

Comments

@gcacars
Copy link
Contributor

@gcacars gcacars commented Aug 1, 2016

Blaze dynamic attributes doesn't work properly with attribute hidden.

If you use:

helperName(){
    return {
        checked: false
}

It works great, removing the checked attribute.
But when you use:

helperName(){
    return {
        hidden: false
}

Blaze creates a html with:

hidden="false"

that occurs in an hidden element.

@mitar mitar added the bug label Aug 1, 2016
@mitar
Copy link
Collaborator

@mitar mitar commented Aug 1, 2016

Probably it just has to be added here: https://github.com/meteor/blaze/blob/master/packages/blaze/attrs.js#L296

This could be a simple pull request. Would you like to contribute it?

Also, there are probably some other new HTML5 attributes likes that.

gcacars added a commit to gcacars/blaze that referenced this issue Sep 18, 2016
- Alphabetic order for constructors of HTML elements
- Issue meteor#52, PR meteor#102
@mitar mitar closed this in #102 Sep 26, 2016
mitar added a commit that referenced this issue Dec 31, 2016
Reverted #102 and made a different fix for removing attributes for
`false` values in dynamic attributes (#52). Fixes #151.
@mitar
Copy link
Collaborator

@mitar mitar commented Dec 31, 2016

A different fix has been implemented in 84c58a6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.