[Bug] Blaze: hidden html attribute does not work properly #52

Closed
gcacars opened this Issue Aug 1, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@gcacars
Contributor

gcacars commented Aug 1, 2016

Blaze dynamic attributes doesn't work properly with attribute hidden.

If you use:

helperName(){
    return {
        checked: false
}

It works great, removing the checked attribute.
But when you use:

helperName(){
    return {
        hidden: false
}

Blaze creates a html with:

hidden="false"

that occurs in an hidden element.

@mitar mitar added the bug label Aug 1, 2016

@mitar

This comment has been minimized.

Show comment
Hide comment
@mitar

mitar Aug 1, 2016

Collaborator

Probably it just has to be added here: https://github.com/meteor/blaze/blob/master/packages/blaze/attrs.js#L296

This could be a simple pull request. Would you like to contribute it?

Also, there are probably some other new HTML5 attributes likes that.

Collaborator

mitar commented Aug 1, 2016

Probably it just has to be added here: https://github.com/meteor/blaze/blob/master/packages/blaze/attrs.js#L296

This could be a simple pull request. Would you like to contribute it?

Also, there are probably some other new HTML5 attributes likes that.

gcacars added a commit to gcacars/blaze that referenced this issue Sep 18, 2016

Add Tests to better support for HTML5 attributes
- Alphabetic order for constructors of HTML elements
- Issue #52, PR #102

@mitar mitar closed this in #102 Sep 26, 2016

mitar added a commit that referenced this issue Dec 31, 2016

Fixes regression reported in #151.
Reverted #102 and made a different fix for removing attributes for
`false` values in dynamic attributes (#52). Fixes #151.
@mitar

This comment has been minimized.

Show comment
Hide comment
@mitar

mitar Dec 31, 2016

Collaborator

A different fix has been implemented in 84c58a6.

Collaborator

mitar commented Dec 31, 2016

A different fix has been implemented in 84c58a6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment