Better support for HTML5 attributes by gcacars · Pull Request #102 · meteor/blaze

gcacars · 2016-09-17T21:27:28Z

Better support for HTML5 attributes in Spacebars helpers. Before HTML5 boolean attributes is not handled properly.
Fixes: #52

Better support for HTML5 attributes in Spacebars Helpers. Before HTML5 is not handled properly.

apollo-cla · 2016-09-17T21:27:28Z

@gcacars: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

mitar · 2016-09-17T22:05:00Z

packages/blaze/attrs.js

+    return new BooleanHandler(name, value);
+  } else if (name === 'spellcheck' && elem.contentEditable === 'true' ||
+             (elem.tagName === 'TEXTAREA' ||
+              (elem.tagName === 'INPUT' && elem.type !== 'password'))) {


Hm, I think in our code style we are aligning all those (?

Can you improve order/readability/add more parenthesis here because it is unclear how this conditions combine?

Changed. This way is better?

mitar · 2016-09-17T22:06:10Z

Can you please also add some tests for these changes?

mitar · 2016-09-17T22:21:39Z

packages/blaze/attrs.js

+    return new BooleanHandler(name, value);
+  } else if ((name === 'spellcheck' && elem.contentEditable === 'true') ||
+             (name === 'spellcheck' && elem.tagName === 'TEXTAREA') ||
+             (name === 'spellcheck' && elem.tagName === 'INPUT' && elem.type !== 'password')) {


Hm, maybe:

(name === 'spellcheck' && (elem.contentEditable === 'true' || elem.tagName === 'TEXTAREA' || (elem.tagName === 'INPUT' && elem.type !== 'password'))

Hmmm... right, I understood now! contenteditable was wrong before. Changed.

mitar · 2016-09-17T22:34:21Z

packages/blaze/attrs.js

+             name === 'controls' || name === 'loop' || name === 'muted')) {
+    return new BooleanHandler(name, value);
+  } else if (name === 'spellcheck' && 
+            (elem.contentEditable === 'true' || elem.tagName === 'TEXTAREA' || 


Indent this for one space.

Changed. I did this to be clear that a parenthesis is inside another.

Hm, I thought you will add one space, not remove it. ;-)

So that second and third are indented once, but at the same level.

Sorry, I had not understood. Now is correct?

mitar · 2016-09-17T22:35:02Z

Also, add tests please.

gcacars · 2016-09-18T01:35:35Z

I have no idea which tests you need. Can you help me with this?

mitar · 2016-09-18T02:04:52Z

Tests. Something like this, just for boolean variables. So you would like to make sure some of those variables are rendered as boolean variables.

- Alphabetic order for constructors of HTML elements - Issue meteor#52, PR meteor#102

mitar · 2016-09-18T04:08:21Z

Tests failed on CircleCI. I am rerunning them.

- Removed autocomplete (not a boolean attribute) - Fix names of DOM properties

mitar · 2016-09-18T04:38:58Z

Hm, why those attributes have to be camel case?

- Spellcheck attribute is a boolean, but is handled like strings. - Fix iframe sandbox with others values - Removed <script> async

- Spellcheck attribute is a boolean, but is handled like strings. - Removed <script> async

mitar · 2016-09-18T05:24:11Z

Can you explain why removing those?

gcacars · 2016-09-18T05:25:16Z

Fixed some bugs. I removed that script async for now. I don't know what happened with him.
Spellcheck has values "true" and "false", is not a trully boolean

speelcheck="true"

mitar · 2016-09-18T05:25:45Z

Also, add a line to HISTORY file explaining this pull request. So that once it is merged, history will be up-to-date. See example of split templating package for the format of the line I think suitable for this pull request as well.

mitar · 2016-09-18T05:26:32Z

Good that we have tests. :-) Please add tests for all those cases you found as tricky.

mitar · 2016-09-18T06:12:36Z

Tell me when you think this is ready and complete.

gcacars · 2016-09-26T02:56:35Z

@mitar for me, it's all ok.

mitar · 2016-09-26T05:51:16Z

Thanks!

mitar · 2016-12-30T23:59:22Z

packages/blaze/attrs.js

+  } else if (elem.tagName === 'FORM' && name === 'novalidate') {
+    return new BooleanHandler(name, value);
+  } else if (elem.tagName === 'IFRAME' && name === 'sandbox' && !value) {
+    // Disable sandbox mode (others values will be handled as a normal attr)


@gcacars: Why is sandbox handled differently?

Because we can have:
<iframe sandbox>
And this way, the attribute is simply true or false.
Or we can have this others values:

<iframe sandbox="allow-forms"> <iframe sandbox="allow-pointer-lock">

Reverted #102 and made a different fix for removing attributes for `false` values in dynamic attributes (#52). Fixes #151.

mitar · 2016-12-31T08:52:42Z

A different fix has been implemented in 84c58a6.

Better support for HTML5 attributes

4b53551

Better support for HTML5 attributes in Spacebars Helpers. Before HTML5 is not handled properly.

Correct sandbox value

0532413

mitar reviewed Sep 17, 2016

View reviewed changes

gcacars added 2 commits September 17, 2016 19:14

Readability of spellcheck

7678bd7

Removed tabs

9a48fd6

mitar reviewed Sep 17, 2016

View reviewed changes

Correction of elem.contentEditable

9a124bc

mitar reviewed Sep 17, 2016

View reviewed changes

Indentation

b54ea02

gcacars added 2 commits September 17, 2016 22:58

Fixed Unexpected token

0ab0370

Indentation+

00e0c3e

Add Tests to better support for HTML5 attributes

44c09a4

- Alphabetic order for constructors of HTML elements - Issue meteor#52, PR meteor#102

gcacars added 2 commits September 18, 2016 01:36

Fix JS HTML attribute names

e38017c

- Removed autocomplete (not a boolean attribute) - Fix names of DOM properties

Removed autocomplete property

2862bf5

gcacars added 2 commits September 18, 2016 02:22

Removed spellcheck property

c5b257e

- Spellcheck attribute is a boolean, but is handled like strings. - Fix iframe sandbox with others values - Removed <script> async

Removed spellcheck test

c476a9e

- Spellcheck attribute is a boolean, but is handled like strings. - Removed <script> async

Changed history do PR meteor#102

f9316ed

Pass a boolean value to BooleanHandler when IFrame

caa4775

gcacars added 3 commits September 19, 2016 21:36

More tests for iframe mode sandbox

361febc

Merge branch 'master' into patch-1

ce519fe

Flush Tracker changes

d327d66

gcacars closed this Sep 26, 2016

gcacars reopened this Sep 26, 2016

mitar merged commit e9959eb into meteor:master Sep 26, 2016

gcacars deleted the patch-1 branch October 1, 2016 00:02

mitar mentioned this pull request Nov 10, 2016

After upgrading to 2.2.0, <input> tag 'readonly' attribute is not rendered #151

Closed

mitar reviewed Dec 30, 2016

View reviewed changes

mitar added a commit that referenced this pull request Dec 31, 2016

Fixes regression reported in #151.

84c58a6

Reverted #102 and made a different fix for removing attributes for `false` values in dynamic attributes (#52). Fixes #151.

Uh oh!

Conversation

gcacars commented Sep 17, 2016 • edited by mitar Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

apollo-cla commented Sep 17, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mitar commented Sep 17, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mitar commented Sep 17, 2016

Uh oh!

gcacars commented Sep 18, 2016

Uh oh!

mitar commented Sep 18, 2016

Uh oh!

mitar commented Sep 18, 2016

Uh oh!

mitar commented Sep 18, 2016

Uh oh!

mitar commented Sep 18, 2016

Uh oh!

gcacars commented Sep 18, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mitar commented Sep 18, 2016

Uh oh!

mitar commented Sep 18, 2016

Uh oh!

mitar commented Sep 18, 2016

Uh oh!

gcacars commented Sep 26, 2016

Uh oh!

mitar commented Sep 26, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mitar commented Dec 31, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gcacars commented Sep 17, 2016 •

edited by mitar

Loading

gcacars commented Sep 18, 2016 •

edited

Loading