Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch versions explicitly #62

Merged
merged 2 commits into from Nov 15, 2018

Conversation

Projects
None yet
5 participants
@wojtkowiak
Copy link
Contributor

commented Sep 14, 2018

This changes switching versions to be done explicitly with call to WebAppLocalServer.switchToPendingVersion instead of trying to switch every time a browser reload is detected.

This is another part of extracted fixes from @matdurand's commits.

This and the other PRs were running on production in my company's fork more than 1 year now.

Refs:
#48
meteor/meteor#8063 (comment)

Fixes: #29

Switch versions explicitly with call to `WebAppLocalServer.switchToPe…
…ndingVersion` instead of trying to switch every time a browser reload is detected
@benjamn

This comment has been minimized.

Copy link
Member

commented Sep 18, 2018

Any idea about those test failures?

@KoenLav

This comment has been minimized.

Copy link

commented Sep 27, 2018

@benjamn AFAICT the changes in this PR are unrelated to these errors; they all mention 403 responses.

@KoenLav

This comment has been minimized.

Copy link

commented Oct 21, 2018

@wojtkowiak do these changes mean that Meteor will no longer automatically switch to a new version, whenever it becomes available, but we have to call this newly added function to switch versions?

I think that would be nice, but it should definitely be configurable (I guess that would need to happen in the package responsible for hot-reload rather than this cordova plugin though).

@menelike

This comment has been minimized.

Copy link

commented Oct 22, 2018

@KoenLav take a look at meteor/meteor#10219

@benjamn benjamn merged commit 319cd32 into meteor:master Nov 15, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@lorensr

This comment has been minimized.

Copy link

commented Jan 12, 2019

image

Maybe related to test failures? Not clear to me why the testing if statement is taken out

zhang2118 pushed a commit to zhang2118/cordova-plugin-meteor-webapp that referenced this pull request Jan 13, 2019

@menelike menelike referenced this pull request Jan 14, 2019

Merged

Release 1.8.1 #10248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.