Skip to content
This repository has been archived by the owner on Oct 2, 2021. It is now read-only.

Switch versions explicitly #62

Merged
merged 2 commits into from Nov 15, 2018

Conversation

wojtkowiak
Copy link
Contributor

This changes switching versions to be done explicitly with call to WebAppLocalServer.switchToPendingVersion instead of trying to switch every time a browser reload is detected.

This is another part of extracted fixes from @matdurand's commits.

This and the other PRs were running on production in my company's fork more than 1 year now.

Refs:
#48
meteor/meteor#8063 (comment)

Fixes: #29

…ndingVersion` instead of trying to switch every time a browser reload is detected
@benjamn
Copy link
Contributor

benjamn commented Sep 18, 2018

Any idea about those test failures?

@KoenLav
Copy link

KoenLav commented Sep 27, 2018

@benjamn AFAICT the changes in this PR are unrelated to these errors; they all mention 403 responses.

@KoenLav
Copy link

KoenLav commented Oct 21, 2018

@wojtkowiak do these changes mean that Meteor will no longer automatically switch to a new version, whenever it becomes available, but we have to call this newly added function to switch versions?

I think that would be nice, but it should definitely be configurable (I guess that would need to happen in the package responsible for hot-reload rather than this cordova plugin though).

@menelike
Copy link

@KoenLav take a look at meteor/meteor#10219

@benjamn benjamn merged commit 319cd32 into meteor:master Nov 15, 2018
@lorensr
Copy link

lorensr commented Jan 12, 2019

image

Maybe related to test failures? Not clear to me why the testing if statement is taken out

zhang2118 pushed a commit to zhang2118/cordova-plugin-meteor-webapp that referenced this pull request Jan 13, 2019
mslobodan added a commit to mslobodan/reloader that referenced this pull request Aug 29, 2019
…r-webapp#62.

This version of package requires you to call Reloader.configure in order to activate this package.
mslobodan added a commit to mslobodan/reloader that referenced this pull request Aug 29, 2019
…r-webapp#62.

This version of package requires you to call Reloader.configure in order to activate this package.
mslobodan added a commit to mslobodan/reloader that referenced this pull request Aug 29, 2019
…r-webapp#62.

This version of package requires you to call Reloader.configure in order to activate this package.
mslobodan added a commit to mslobodan/reloader that referenced this pull request Aug 29, 2019
…r-webapp#62.

This version of package requires you to call Reloader.configure in order to activate this package.
mslobodan added a commit to mslobodan/reloader that referenced this pull request Aug 29, 2019
…r-webapp#62.

This version of package requires you to call Reloader.configure in order to activate this package.
mslobodan added a commit to mslobodan/reloader that referenced this pull request Aug 29, 2019
…r-webapp#62.

This version of package requires you to call Reloader.configure in order to activate this package.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert to last good known version fires on external urls (Android).
5 participants