Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed arrow functions for Mocha tests. #323

Merged
merged 1 commit into from Apr 1, 2016

Conversation

@hwillson
Copy link
Member

commented Apr 1, 2016

Hi guys - this relates to #318 (removing arrow functions for Mocha tests and updating the sample eslint rules accordingly). I'll aim to submit a similar PR for the todos app shortly, to keep things in synch. Thanks!

@stubailo

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2016

Can we add a short comment in the first code snippet that says why we're not using arrow functions?

Thanks!

@stubailo stubailo merged commit 4b649c6 into meteor:master Apr 1, 2016

2 checks passed

CLA Author has signed the Meteor CLA.
Details
ci/circleci Your tests passed on CircleCI!
Details
@hwillson

This comment has been minimized.

Copy link
Member Author

commented Apr 1, 2016

Good idea - added via #326. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.