Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
This comment has been minimized.
This comment has been minimized.
|
I signed the CLA :) |
This comment has been minimized.
This comment has been minimized.
|
Looks great to me! Merging. |
stubailo
merged commit 74740de
into
meteor:master
Apr 1, 2016
This comment has been minimized.
This comment has been minimized.
|
Fastest merge ever, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
gadicc commentedApr 1, 2016
Further to https://forums.meteor.com/t/best-way-to-import-blaze-templates-into-react/20288:
Summary of changes:
"Blaze Templates in React Components""Using with Blaze"to"React Components in Blaze Templates"<span id="using-with-blaze"><!-- don't break old links --></span>to preserve the link."Using"from both titles to avoid word-wrap.#blaze-in-reactand#react-in-blazeare simple enough to type by hand.I was sure there was a section somewhere involving hand-wrapping accounts-ui, but I can't seem to find it anywhere now, even in the history.
Happy to continue to discuss and rebase any changes.