New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: Using Blaze Templates in React Components section #325

Merged
merged 1 commit into from Apr 1, 2016

Conversation

Projects
None yet
2 participants
@gadicc
Contributor

gadicc commented Apr 1, 2016

Further to https://forums.meteor.com/t/best-way-to-import-blaze-templates-into-react/20288:

Summary of changes:

  1. Adds the mentioned section, "Blaze Templates in React Components"
  2. Renames "Using with Blaze" to "React Components in Blaze Templates"
  3. Uses <span id="using-with-blaze"><!-- don't break old links --></span> to preserve the link.
  4. Removed the word "Using" from both titles to avoid word-wrap.
  5. I think the #blaze-in-react and #react-in-blaze are simple enough to type by hand.

I was sure there was a section somewhere involving hand-wrapping accounts-ui, but I can't seem to find it anywhere now, even in the history.

Happy to continue to discuss and rebase any changes.

@gadicc

This comment has been minimized.

Contributor

gadicc commented Apr 1, 2016

I signed the CLA :)

@stubailo

This comment has been minimized.

Contributor

stubailo commented Apr 1, 2016

Looks great to me! Merging.

@stubailo stubailo merged commit 74740de into meteor:master Apr 1, 2016

1 of 2 checks passed

CLA Author has not signed the Meteor CLA.
Details
ci/circleci Your tests passed on CircleCI!
Details
@gadicc

This comment has been minimized.

Contributor

gadicc commented Apr 1, 2016

Fastest merge ever, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment