Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
skirunman
added some commits
Apr 3, 2016
stubailo
reviewed
Apr 4, 2016
content/writing-packages.md
Outdated
| @@ -47,6 +49,8 @@ The `package.js` file is the main file in every Meteor package. This is a JavaSc | ||
| In this guide article, we will go over some important points for building packages, but we won't explain every part of the `package.js` API. To learn about all of the options, [read about the `package.js` API in the Meteor docs.](http://docs.meteor.com/#/full/packagejs) | ||
| Don't forget to run `meteor add [my-package]` once you have finished developing your package in order to use it, even if the package is for internal use only and you don't intend to publish the package to Atmosphere. |
This comment has been minimized.
This comment has been minimized.
stubailo
Apr 4, 2016
Contributor
This is specifically for local packages in an application, would be good to clarify that!
This comment has been minimized.
This comment has been minimized.
skirunman
Apr 4, 2016
Contributor
Not 100% sure what you want clarified, but I tweaked the text. Let me know if this is what you wanted.
stubailo
changed the title from
Add more content on using Atmosphere packages
to
Add more content on writing Atmosphere packages
Apr 4, 2016
skirunman
added some commits
Apr 4, 2016
This comment has been minimized.
This comment has been minimized.
|
Alright, looks good to me! |
This comment has been minimized.
This comment has been minimized.
|
Merged, thanks! b3324df |
stubailo
closed this
Apr 4, 2016
skirunman
deleted the
skirunman:packages-fix
branch
Apr 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
skirunman commentedApr 3, 2016
Thanks for submitting a PR! We'll try to look at it as soon as possible.
If you are adding significant new content, please take a moment to include an update to the changelog in your PR.