New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more content on writing Atmosphere packages #339

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@skirunman
Contributor

skirunman commented Apr 3, 2016

Thanks for submitting a PR! We'll try to look at it as soon as possible.

If you are adding significant new content, please take a moment to include an update to the changelog in your PR.

skirunman added some commits Apr 3, 2016

@@ -47,6 +49,8 @@ The `package.js` file is the main file in every Meteor package. This is a JavaSc
In this guide article, we will go over some important points for building packages, but we won't explain every part of the `package.js` API. To learn about all of the options, [read about the `package.js` API in the Meteor docs.](http://docs.meteor.com/#/full/packagejs)
Don't forget to run `meteor add [my-package]` once you have finished developing your package in order to use it, even if the package is for internal use only and you don't intend to publish the package to Atmosphere.

This comment has been minimized.

@stubailo

stubailo Apr 4, 2016

Contributor

This is specifically for local packages in an application, would be good to clarify that!

This comment has been minimized.

@skirunman

skirunman Apr 4, 2016

Contributor

Not 100% sure what you want clarified, but I tweaked the text. Let me know if this is what you wanted.

@stubailo stubailo changed the title from Add more content on using Atmosphere packages to Add more content on writing Atmosphere packages Apr 4, 2016

skirunman added some commits Apr 4, 2016

@stubailo

This comment has been minimized.

Contributor

stubailo commented Apr 4, 2016

Alright, looks good to me!

@stubailo

This comment has been minimized.

Contributor

stubailo commented Apr 4, 2016

Merged, thanks! b3324df

@stubailo stubailo closed this Apr 4, 2016

@skirunman skirunman deleted the skirunman:packages-fix branch Apr 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment