Skip to content
This repository has been archived by the owner on Oct 24, 2021. It is now read-only.

Add back in build tool default loading order rules #340

Merged
merged 3 commits into from
Apr 4, 2016

Conversation

skirunman
Copy link
Contributor

Thanks for submitting a PR! We'll try to look at it as soon as possible.

If you are adding significant new content, please take a moment to include an update to the changelog in your PR.

@skirunman
Copy link
Contributor Author

This should fix #336

@skirunman
Copy link
Contributor Author

This includes some cross reference changes to mobile.md. Probably need to confirm with @martijnwalraven that the cordova-build-override/ directory still works.

@stubailo
Copy link
Contributor

stubailo commented Apr 4, 2016

Yeah this looks great to me. I expect the build override still works, since that would be a big backcompat change and wasn't mentioned in http://guide.meteor.com/1.3-migration.html#breaking-changes-mobile

@stubailo stubailo merged commit b4ce2af into meteor:master Apr 4, 2016
@stubailo
Copy link
Contributor

stubailo commented Apr 4, 2016

Awesome work, this is a great new addition to the guide!

@martijnwalraven
Copy link
Contributor

The cordova-build-override mechanism still works, but I didn't include it in the guide because I don't think it is ever a good solution and it can lead to a lot of trouble.

The problem is that is overrides complete files, so if you use it to write your own config.xml for example, you lose all configuration information set by the build process and by installed plugins, which will likely break your app.

Cordova has a <config-file> tag as part of plugin.xml that allows you to selectively change parts of configuration files, including config.xml, so if you absolutely must make changes, the recommendation would be to write a dummy plugin. If we are including advanced build customization in the guide, I think we should mention that instead.

@stubailo
Copy link
Contributor

stubailo commented Apr 4, 2016

@martijnwalraven OK, sorry I merged that if it isn't recommended! Please change it back if you think it is best.

@martijnwalraven
Copy link
Contributor

@stubailo: I've removed the recommendation to override config.xml and mentioned the plugin alternative in 4397c43.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants