New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed reference from Atmosphere to Meteor #390

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@jamielob
Contributor

jamielob commented Apr 20, 2016

No description provided.

@tmeasday

This comment has been minimized.

Contributor

tmeasday commented Apr 20, 2016

Hey @jamielob, thanks. We intentionally refer to them as "Atmosphere packages" to avoid confusion about our support for npm packages.

@tmeasday tmeasday closed this Apr 20, 2016

@jamielob

This comment has been minimized.

Contributor

jamielob commented Apr 20, 2016

Hi @tmeasday - Sorry didn't get that from looking at it initially. So is the entire Adding files and assets section specific to Atmosphere? If that's the case then visually I would recommend that it is either moved underneath or merged with the Creating an Atmosphere Package section so that it's clearer.

@tmeasday

This comment has been minimized.

Contributor

tmeasday commented Apr 20, 2016

Hmm, that's a good point @jamielob.

Everything below "Creating an Atmosphere Package" is specific to atmosphere and doesn't apply to npm.

I'm not sure what the best approach here is as having 90% of the article under a single heading is kind of silly. Do you think it would have helped if it just said something like "The rest of the content of this article is specific to Atmosphere packages" in the npm package section?

@jamielob

This comment has been minimized.

Contributor

jamielob commented Apr 20, 2016

I probably would have missed that sentence. I'm not sure if you're open to this, but since there seem to be a lot of NPM vs Atmosphere specific information in both the Using Packages and Writing Packages sections I would re-work the grouping of the Build section to something like below. Giving a clearer route to deprecating the Atmosphere information and improving the npm.

BUILD

-Atmosphere vs. npm

-Using Atmosphere Packages
--Installing Atmosphere Packages
--Using Atmosphere Packages
--Peer npm Dependencies
--Overriding with a local version

-Writing Atmosphere Packages
--Creating an Atmosphere Package
--Adding files and assets
--Exporting
--Dependencies
--Cordova plugins
--Testing packages
--Local vs. published packages

-Using npm Packages
--Installing npm Packages
--Using npm Packages
--Using Shrinkpack

-Writing npm Packages
--Including in your app
--Publishing your package
@jamielob

This comment has been minimized.

Contributor

jamielob commented Apr 20, 2016

P.s. Happy to help in any way I can with this @tmeasday

@tmeasday

This comment has been minimized.

Contributor

tmeasday commented Apr 21, 2016

Hey @jamielob - sounds great!

Sure, send a PR and I'll accept it!

Reminder to self: ensure redirects work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment