Skip to content
This repository has been archived by the owner on Oct 24, 2021. It is now read-only.

Added simple react / enzyme docs #466

Merged
merged 2 commits into from
Jun 2, 2016
Merged

Conversation

shilman
Copy link
Contributor

@shilman shilman commented May 28, 2016

@tmeasday Per your request, I've added a few comments about React unit testing to support recently-merged Todos app PR of the same. Happy to incorporate any suggestions for improvement!

TODO:

  • If this is a significant change, update CHANGELOG.md
  • Use <h2 id="foo"> instead of ## Foo for headers
  • Leave a blank line after each header

@tmeasday
Copy link
Contributor

tmeasday commented Jun 2, 2016

This is great. @lorensr / @stubailo any thoughts on whether this should be here in the Testing article, or perhaps in the React article? I'd probably vote for here, it makes sense to have it here where you can directly compare the two styles.

We'll need to add a redirect for the old simple-unit-test -> simple-blaze-unit-test

@lorensr
Copy link
Contributor

lorensr commented Jun 2, 2016

Nice, lgtm. And testing good location

@tmeasday tmeasday merged commit cb44cf3 into meteor:master Jun 2, 2016
tmeasday added a commit that referenced this pull request Jun 2, 2016
@tmeasday
Copy link
Contributor

tmeasday commented Jun 2, 2016

Added a redirect in 8a5a73a

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants