Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added simple react / enzyme docs #466

Merged
merged 2 commits into from Jun 2, 2016
Merged

Conversation

@shilman
Copy link
Contributor

@shilman shilman commented May 28, 2016

@tmeasday Per your request, I've added a few comments about React unit testing to support recently-merged Todos app PR of the same. Happy to incorporate any suggestions for improvement!

TODO:

  • If this is a significant change, update CHANGELOG.md
  • Use <h2 id="foo"> instead of ## Foo for headers
  • Leave a blank line after each header
shilman added 2 commits May 28, 2016
@tmeasday
Copy link
Contributor

@tmeasday tmeasday commented Jun 2, 2016

This is great. @lorensr / @stubailo any thoughts on whether this should be here in the Testing article, or perhaps in the React article? I'd probably vote for here, it makes sense to have it here where you can directly compare the two styles.

We'll need to add a redirect for the old simple-unit-test -> simple-blaze-unit-test

@lorensr
Copy link
Member

@lorensr lorensr commented Jun 2, 2016

Nice, lgtm. And testing good location

@tmeasday tmeasday merged commit cb44cf3 into meteor:master Jun 2, 2016
2 checks passed
2 checks passed
CLA Author has signed the Meteor CLA.
Details
ci/circleci Your tests passed on CircleCI!
Details
tmeasday added a commit that referenced this pull request Jun 2, 2016
@tmeasday
Copy link
Contributor

@tmeasday tmeasday commented Jun 2, 2016

Added a redirect in 8a5a73a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants