Skip to content
This repository has been archived by the owner. It is now read-only.

Testing: Replace factory to dburles:factory #598

Merged
merged 3 commits into from Jan 13, 2017

Conversation

@abernix
Copy link
Member

@abernix abernix commented Jan 4, 2017

In the testing section of the guide (amongst others), the guide references the Meteor "Todos" app: https://github.com/meteor/todos

Previously, factory was a locally forked Meteor package within the Todos repo which was a fork of dburles:factory with (minimal) tweaks. See discussion in:

With the landing of meteor/todos#202, the Todos application now utilizes dburles:factory. This commit gives the same treatment as that PR provided to meteor/todos (https://github.com/meteor/todos/pull/202/files).

Closes #576

/cc @hwillson @dburles

abernix added 2 commits Jan 4, 2017
In the testing section of the guide (amongst others), the guide references the Meteor "Todos" app: https://github.com/meteor/todos

Previously, `factory` was a locally forked Meteor package within the Todos repo which was a fork of `dburles:factory` with (minimal) tweaks.  See discussion in:

* meteor/todos#193
* meteor/todos#96

With the landing of meteor/todos#202, the Todos application now utilizes `dburles:factory`.  This commit gives the same treatment as that PR provided to `meteor/todos` (https://github.com/meteor/todos/pull/202/files).

Closes meteor#576
@hwillson
Copy link
Contributor

@hwillson hwillson commented Jan 4, 2017

Looks great @abernix!

Loading

@abernix abernix merged commit c12e5d2 into meteor:master Jan 13, 2017
1 check passed
Loading
@abernix
Copy link
Member Author

@abernix abernix commented Jan 13, 2017

Self-merging based on the "thumbs ups" from the two super-relevant participants in this.

Thanks, @hwillson and @dburles! 😸

Loading

@abernix abernix deleted the feature/fix-576 branch Jan 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants