Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Replace `factory` to `dburles:factory` #598

Merged
merged 3 commits into from Jan 13, 2017

Conversation

@abernix
Copy link
Member

commented Jan 4, 2017

In the testing section of the guide (amongst others), the guide references the Meteor "Todos" app: https://github.com/meteor/todos

Previously, factory was a locally forked Meteor package within the Todos repo which was a fork of dburles:factory with (minimal) tweaks. See discussion in:

With the landing of meteor/todos#202, the Todos application now utilizes dburles:factory. This commit gives the same treatment as that PR provided to meteor/todos (https://github.com/meteor/todos/pull/202/files).

Closes #576

/cc @hwillson @dburles

abernix added some commits Jan 4, 2017

Testing: Replace `factory` to `dburles:factory`
In the testing section of the guide (amongst others), the guide references the Meteor "Todos" app: https://github.com/meteor/todos

Previously, `factory` was a locally forked Meteor package within the Todos repo which was a fork of `dburles:factory` with (minimal) tweaks.  See discussion in:

* meteor/todos#193
* meteor/todos#96

With the landing of meteor/todos#202, the Todos application now utilizes `dburles:factory`.  This commit gives the same treatment as that PR provided to `meteor/todos` (https://github.com/meteor/todos/pull/202/files).

Closes #576
@hwillson

This comment has been minimized.

Copy link
Member

commented Jan 4, 2017

Looks great @abernix!

@abernix abernix merged commit c12e5d2 into meteor:master Jan 13, 2017

1 check passed

CLA Author has signed the Meteor CLA.
Details
@abernix

This comment has been minimized.

Copy link
Member Author

commented Jan 13, 2017

Self-merging based on the "thumbs ups" from the two super-relevant participants in this.

Thanks, @hwillson and @dburles! 😸

@abernix abernix deleted the abernix:feature/fix-576 branch Jan 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.