Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added paragraph on TypeScript conditional imports. #613

Merged
merged 2 commits into from Mar 22, 2017
Merged

Conversation

@realyze
Copy link
Contributor

@realyze realyze commented Feb 28, 2017

TODO:

  • If this is a significant change, update CHANGELOG.md
  • Use <h2 id="foo"> instead of ## Foo for headers
  • Leave a blank line after each header
@realyze
Copy link
Contributor Author

@realyze realyze commented Feb 28, 2017

@realyze realyze force-pushed the realyze:master branch from 5121085 to 1c9ee27 Feb 28, 2017
@abernix
Copy link
Member

@abernix abernix commented Mar 10, 2017

This looks great! Thank you for taking the time do this (and research it!).

Did you have any additional feelings about this update after reading the information about dynamic imports in meteor/meteor#8327 (comment)?

If not, I'm happy to merge this!

@realyze
Copy link
Contributor Author

@realyze realyze commented Mar 10, 2017

Thanks @abernix . The bottomline of meteor/meteor#8327 (comment) is basically that adding dynamic import to TypeScript will be quite a challenge for the TS team so it probably won't happen anytime soon (if at all).

When Meteor 1.5 is released, I guess it will make sense to update this by mentioning the module.dynamicImport workaround.

@realyze
Copy link
Contributor Author

@realyze realyze commented Mar 10, 2017

BTW I also wrote a short post about it which explains it with a Meteor code example on my blog but I didn't want to link to my personal blog from the guide. Dunno if that's frowned upon or legit...you tell me, I guess. :-)

@abernix
Copy link
Member

@abernix abernix commented Mar 21, 2017

@realyze If it's relevant and we don't have a good place to put it right now (both of these things seem true), go for it – I approve of the link you've provided.

I will make the disclaimer that at some point and time in the future, I could see us having a have a dedicated* TypeScript section where this would fit very well (although, hopefully at some point we can make this exception obsolete). 😄

Edit: By "Dedicated", I mean "much larger" #531.

@realyze
Copy link
Contributor Author

@realyze realyze commented Mar 22, 2017

@abernix Cool, I've updated the patch.

Having a dedicated (and much larger, yes :) ) TS section would be awesome. It certainly appears TypeScript's adoption is increasing quite rapidly and I believe having an easy to follow and readable guide for TS would be encouraging to new Meteor users. There definitely are some gotchas when working with Meteor/TS combo.

@lorensr lorensr merged commit 21310c2 into meteor:master Mar 22, 2017
1 check passed
1 check passed
CLA Author has signed the Meteor CLA.
Details
@lorensr
Copy link
Member

@lorensr lorensr commented Mar 22, 2017

Thanks @realyze ! 😊

@michaeljota
Copy link

@michaeljota michaeljota commented Jun 23, 2017

FYI: TS 2.4 add supports for Dynamic Imports 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.