Skip to content
This repository has been archived by the owner on Oct 24, 2021. It is now read-only.

Added paragraph on TypeScript conditional imports. #613

Merged
merged 2 commits into from Mar 22, 2017

Conversation

realyze
Copy link
Contributor

@realyze realyze commented Feb 28, 2017

TODO:

  • If this is a significant change, update CHANGELOG.md
  • Use <h2 id="foo"> instead of ## Foo for headers
  • Leave a blank line after each header

@realyze
Copy link
Contributor Author

realyze commented Feb 28, 2017

meteor/meteor#8428

@abernix
Copy link
Contributor

abernix commented Mar 10, 2017

This looks great! Thank you for taking the time do this (and research it!).

Did you have any additional feelings about this update after reading the information about dynamic imports in meteor/meteor#8327 (comment)?

If not, I'm happy to merge this!

@realyze
Copy link
Contributor Author

realyze commented Mar 10, 2017

Thanks @abernix . The bottomline of meteor/meteor#8327 (comment) is basically that adding dynamic import to TypeScript will be quite a challenge for the TS team so it probably won't happen anytime soon (if at all).

When Meteor 1.5 is released, I guess it will make sense to update this by mentioning the module.dynamicImport workaround.

@realyze
Copy link
Contributor Author

realyze commented Mar 10, 2017

BTW I also wrote a short post about it which explains it with a Meteor code example on my blog but I didn't want to link to my personal blog from the guide. Dunno if that's frowned upon or legit...you tell me, I guess. :-)

@abernix
Copy link
Contributor

abernix commented Mar 21, 2017

@realyze If it's relevant and we don't have a good place to put it right now (both of these things seem true), go for it – I approve of the link you've provided.

I will make the disclaimer that at some point and time in the future, I could see us having a have a dedicated* TypeScript section where this would fit very well (although, hopefully at some point we can make this exception obsolete). 😄

Edit: By "Dedicated", I mean "much larger" #531.

@realyze
Copy link
Contributor Author

realyze commented Mar 22, 2017

@abernix Cool, I've updated the patch.

Having a dedicated (and much larger, yes :) ) TS section would be awesome. It certainly appears TypeScript's adoption is increasing quite rapidly and I believe having an easy to follow and readable guide for TS would be encouraging to new Meteor users. There definitely are some gotchas when working with Meteor/TS combo.

@lorensr lorensr merged commit 21310c2 into meteor:master Mar 22, 2017
@lorensr
Copy link
Contributor

lorensr commented Mar 22, 2017

Thanks @realyze ! 😊

@michaeljota
Copy link

FYI: TS 2.4 add supports for Dynamic Imports 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants