Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the test driver packages in the testing page #618

Merged
merged 6 commits into from Mar 10, 2017

Conversation

@vjvasilev95
Copy link
Contributor

commented Mar 5, 2017

TODO:

  • If this is a significant change, update CHANGELOG.md
  • Use <h2 id="foo"> instead of ## Foo for headers
  • Leave a blank line after each header

vjvasilev95 added some commits Mar 5, 2017

Update the list of test driver packages for Mocha #617
 - removed the dispatch:mocha-phantomjs driver from the list, as it is no longer supported
 - updated the dispatch:mocha test driver description to mention it now supports client tests as well
@meteor-bot

This comment has been minimized.

Copy link

commented Mar 5, 2017

@vjvasilev95: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@vjvasilev95

This comment has been minimized.

Copy link
Contributor Author

commented Mar 5, 2017

I just noticed that #614 has already covered the change in the listing of the test driver packages, so this part might be considered a duplicate, but the Continuous Integration setup change has not been covered there, so this PR is still valid.

abernix added some commits Mar 10, 2017

Reword Change Log entry for dispatch:mocha.
Also added attribution to the #614 PR from @aldeed.
@abernix
Copy link
Member

left a comment

LGTM. Thanks!

@abernix abernix merged commit 6536ba1 into meteor:master Mar 10, 2017

1 check passed

CLA Author has signed the Meteor CLA.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.