Skip to content
This repository has been archived by the owner on Jun 29, 2021. It is now read-only.

Avoid rebuilding the app three times on error #335

Closed
vbgm opened this issue Oct 21, 2018 · 4 comments
Closed

Avoid rebuilding the app three times on error #335

vbgm opened this issue Oct 21, 2018 · 4 comments

Comments

@vbgm
Copy link

vbgm commented Oct 21, 2018

Description
Since Meteor tries to restart the app three times when there is a development server runtime error, it takes longer time to read error logs, since they are published 3 times.

Suggestion
Make the count of restarts as an option or environment variable.

Details
This has been requested firstly in meteor/meteor#6481, but was closed and suggested to create a feature request.

@benjamn
Copy link
Contributor

benjamn commented Oct 21, 2018

I like this idea, and I would even go further: instead of allowing the restart count to be configured, let's get rid of the multiple restart feature altogether. In more than four years working on Meteor, I have never once seen the second or third restart actually fix any problems.

@vbgm
Copy link
Author

vbgm commented Oct 21, 2018

Great that you like it! I have not seen the second or third restart actually fix any problem, but maybe someone had.. :-)

@benjamn
Copy link
Contributor

benjamn commented Oct 21, 2018

If you (or anyone) is interested in attempting a pull request, here's the relevant code. Of course you could just change that 3 to a 1, but ideally we could clean up any lingering multiple restart logic too.

@StorytellerCZ
Copy link
Collaborator

This has been implemented in Meteor 1.9

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants