Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid rebuilding the app three times on error #335

Open
vblagomir opened this issue Oct 21, 2018 · 3 comments
Open

Avoid rebuilding the app three times on error #335

vblagomir opened this issue Oct 21, 2018 · 3 comments

Comments

@vblagomir
Copy link

@vblagomir vblagomir commented Oct 21, 2018

Description
Since Meteor tries to restart the app three times when there is a development server runtime error, it takes longer time to read error logs, since they are published 3 times.

Suggestion
Make the count of restarts as an option or environment variable.

Details
This has been requested firstly in meteor/meteor#6481, but was closed and suggested to create a feature request.

@benjamn

This comment has been minimized.

Copy link
Member

@benjamn benjamn commented Oct 21, 2018

I like this idea, and I would even go further: instead of allowing the restart count to be configured, let's get rid of the multiple restart feature altogether. In more than four years working on Meteor, I have never once seen the second or third restart actually fix any problems.

@vblagomir

This comment has been minimized.

Copy link
Author

@vblagomir vblagomir commented Oct 21, 2018

Great that you like it! I have not seen the second or third restart actually fix any problem, but maybe someone had.. :-)

@benjamn

This comment has been minimized.

Copy link
Member

@benjamn benjamn commented Oct 21, 2018

If you (or anyone) is interested in attempting a pull request, here's the relevant code. Of course you could just change that 3 to a 1, but ideally we could clean up any lingering multiple restart logic too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.