Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Upgrade Facebook Graph API to use v2.8
In testing for #7715, I discovered that the v2.2 Graph API endpoint was still in use in the `facebook` package which was due to sunset on 2017-03-25. See Facebook Graph API Changelog here: https://developers.facebook.com/docs/apps/changelog When a Graph API endpoint is sunset, it (is claimed) to automatically turn over to the next more recent version, in this case v2.3. v2.3 has a breaking-change over v2.2, notably listed in "Changes from v2.2 to v2.3": > [Oauth Access Token] Format - The response format of https://www.facebook.com/v2.3/oauth/access_token returned when you exchange a code for an access_token now return valid JSON instead of being URL encoded. The new format of this response is {"access_token": {TOKEN}, "token_type":{TYPE}, "expires_in":{TIME}}. We made this update to be compliant with section 5.1 of RFC 6749. This change updates both Graph APIs to v2.8 which has LTS until "At least October 2018".
- Loading branch information
873f13d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it on purpose that the facebook_client.js file still uses API v2.2 ?
873f13d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@williamledoux Good question! Not that I'm aware of. I didn't encounter an issue with that aspect of it when I submitted this, but it's possible that there were no incompatibilities with the
dialog
aspect of the auth process and that Facebook automatically rolled that call into thev2.3
API, which was backward compatible. If you could reproduce a problem (if any!), test the update to a newer API (v2.8
orv2.9
) and submit a pull-request that would be greatly appreciated!873f13d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I cannot make a simple facebook login example work (see my thread). I tried to make my own version of
facebook-oauth
with a v2.8 or v2.9 call but It did not fix the problem. So I am stuck, both for fixing my app and for submitting a pull request on this topic.