Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Remove the 'sass' package, as warned in 0.5.0.

Meteor's sass package wraps the "sass" NPM module, which implements a version of
the Sass language much older than the .sass described at sass-lang.com (and
doesn't implement the current recommended .scss language at all). It also has
poor error handling, so it mostly just ends up confusing users.

The module is unmaintained, and its author now uses stylus/nib (which Meteor
supports: see the stylus package).

If many users want Sass support, we could add this back in wrapping the
"node-sass" package instead (which supports a more recent version of the Sass
language), but for now, just remove it. Meteor still supports Stylus and Less
out of the box.

Fixes #143.
  • Loading branch information...
commit a5cc93ee55901335ebf849d343b4f81e2603b9ba 1 parent c8a9bc9
@glasser glasser authored
View
7 LICENSE.txt
@@ -157,13 +157,6 @@ Copyright (c) 2010 LearnBoost <dev@learnboost.com>
----------
-sass: https://github.com/visionmedia/sass.js
-----------
-
-Copyright (c) 2009 TJ Holowaychuk <tj@vision-media.ca>
-
-
-----------
jquery-waypoints: https://github.com/imakewebthings/jquery-waypoints
----------
View
1  admin/generate-dev-bundle.sh
@@ -78,7 +78,6 @@ npm install gzippo@0.1.7
npm install optimist@0.3.4
npm install coffee-script@1.3.3
npm install less@1.3.0
-npm install sass@0.5.0
npm install stylus@0.29.0
npm install nib@0.8.2
npm install mime@1.2.7
View
1  docs/client/docs.js
@@ -274,7 +274,6 @@ var toc = [
"force-ssl",
"jquery",
"less",
- "sass",
"spiderable",
"stylus",
"showdown",
View
1  docs/client/packages.html
@@ -25,7 +25,6 @@ <h1 id="packages">Packages</h1>
{{> pkg_force_ssl}}
{{> pkg_jquery}}
{{> pkg_less}}
-{{> pkg_sass}}
{{> pkg_spiderable}}
{{> pkg_stylus}}
{{> pkg_showdown}}
View
21 docs/client/packages/sass.html
@@ -1,21 +0,0 @@
-<template name="pkg_sass">
-{{#better_markdown}}
-## `sass`
-
-Sass is a CSS pre-processor with a minimal syntax and powerful dynamic
-expresions. With the `sass` package installed, `.sass` files in your
-application are automatically compiled to CSS and the results are
-included in the client CSS bundle.
-
-See <https://github.com/visionmedia/sass.js> for the JavaScript implementation
-of the Sass language and <http://sass-lang.com/> for the original project.
-
-{{#warning}}
-The Sass JavaScript implementation used by Node is unmaintained and doesn't
-implement the newest language syntax documented at <http://sass-lang.com/>. It
-may be removed from a future version of Meteor; consider using [Less](#less) or
-[Stylus](#stylus) instead.
-{{/warning}}
-
-{{/better_markdown}}
-</template>
View
33 packages/sass/package.js
@@ -1,33 +0,0 @@
-Package.describe({
- summary: "Sassy CSS pre-processor."
-});
-
-var sass = require('sass');
-var fs = require('fs');
-
-Package.register_extension(
- "sass", function (bundle, source_path, serve_path, where) {
- serve_path = serve_path + '.css';
-
- try {
- var contents = fs.readFileSync(source_path);
- var css = sass.render(contents.toString('utf8'));
- // NOTE: sass does not seem to return any sort of error. It just
- // silently ignores bad sass code.
-
- bundle.add_resource({
- type: "css",
- path: serve_path,
- data: new Buffer(css),
- where: where
- });
- } catch (e) {
- // Haven't been able to get sass to throw, but just in case.
- bundle.error(source_path + ": Sass compiler error: " + e.message);
- }
- }
-);
-
-Package.on_test(function (api) {
- api.add_files(['sass_tests.sass', 'sass_tests.js'], 'client');
-});
View
14 packages/sass/sass_tests.js
@@ -1,14 +0,0 @@
-
-Tinytest.add("sass - presence", function(test) {
-
- var d = OnscreenDiv(Meteor.render(function() {
- return '<p class="sass-dashy-left-border"></p>'; }));
- d.node().style.display = 'block';
-
- var p = d.node().firstChild;
- var leftBorder = getStyleProperty(p, 'border-left-style');
- test.equal(leftBorder, "dashed");
-
- d.kill();
-
-});
View
7 packages/sass/sass_tests.sass
@@ -1,7 +0,0 @@
-#sass-tests
- :zoom 1
-
-dashy: dashed
-
-.sass-dashy-left-border
- :border-left 1px !dashy black
Please sign in to comment.
Something went wrong with that request. Please try again.