Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing uglify-es dependency in minifier-js package #10042

Closed
arggh opened this issue Jul 1, 2018 · 3 comments
Closed

Consider replacing uglify-es dependency in minifier-js package #10042

arggh opened this issue Jul 1, 2018 · 3 comments
Assignees
Milestone

Comments

@arggh
Copy link
Contributor

@arggh arggh commented Jul 1, 2018

I'm not too familiar with the drama involved, but apparently some folks are changing uglify-es to either terser or babel-minify.

The claims on uglify-es state that it's unmaintained among a few other bad things, and that it contains some serious bugs, known to create tricky situations especially with React.

Parcel switching to terser
Ledger switching away from uglify
Twitter thread about this

Like I said, I don't have any in-depth knowledge about the situation and this is just a heads-up about something I noticed by chance.

benjamn added a commit that referenced this issue Jul 2, 2018
Thanks to @arrgh for suggesting this replacement: #10042

This may help with lots of issues, most recently #10044 but also #10034,
fall back to `Babel.minify` when `uglify-es` (now `terser`) fails, there
should be fewer problems with `Babel.minify` (parse errors, performance,
memory usage) if `terser` succeeds more often.
@benjamn
Copy link
Member

@benjamn benjamn commented Jul 3, 2018

Done! To try out the new minifier, run meteor update --release 1.7.1-beta.14 or create a new app with meteor create --release 1.7.1-beta.14 your-new-app.

@benjamn benjamn closed this Jul 3, 2018
@benjamn benjamn added this to the Release 1.7.1 milestone Jul 3, 2018
@benjamn benjamn self-assigned this Jul 3, 2018
@arggh
Copy link
Contributor Author

@arggh arggh commented Jul 3, 2018

Well that was fast! 👍

@abernix
Copy link
Member

@abernix abernix commented Jul 3, 2018

I hadn't caught wind of this story change! Thanks for catching this and the suggestion, @arggh! (And @benjamn for making the change!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.