New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node 8.12 to address CPU usage problems related to fibers #10117

Closed
jimrandomh opened this Issue Aug 1, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@jimrandomh
Copy link

jimrandomh commented Aug 1, 2018

Node has a bug fix related to performance with fibers, which is very important to Meteor. Without the fix applied, any Meteor process which creates a large number of fibers will become very slow; switching between fibers is O(n) in the peak number of concurrent fibers the process has ever contained.

The fix is present in Node 10.2.0 and later, and which will be in Node 8.12 as soon as they cut a release, which should be soon. Meteor is currently on Node 8.11, which is affected.

Node 8.12 release PR page: nodejs/node#21593

@harrisonhunter

This comment has been minimized.

Copy link

harrisonhunter commented Aug 2, 2018

This should be handled in this PR: #10090 which looks like it should land in 1.7.1

@macrozone

This comment has been minimized.

Copy link

macrozone commented Sep 11, 2018

node 8.12 has been released! https://nodejs.org/en/blog/release/v8.12.0/

@benjamn

This comment has been minimized.

Copy link
Member

benjamn commented Sep 11, 2018

You can start using Node 8.12.0 in the latest Meteor 1.7.1 release candidates!

meteor update --release 1.7.1-rc.11
@benjamn

This comment has been minimized.

Copy link
Member

benjamn commented Sep 18, 2018

See also #10216, which is why we've reverted the upgrade for now.

@benjamn benjamn modified the milestones: Release 1.8, Release 1.8.1 Oct 6, 2018

benjamn added a commit that referenced this issue Oct 6, 2018

@promentol promentol referenced this issue Oct 30, 2018

Open

Node v8.12 #11

menelike added a commit to risetechnologies/meteor that referenced this issue Nov 5, 2018

@benjamn

This comment has been minimized.

Copy link
Member

benjamn commented Dec 7, 2018

In order to reflect what's been fixed in the Meteor 1.8.1 milestone so far, I'm going to close this issue now, though of course you'll need to run

meteor update --release 1.8.1-beta.8

to get Node 8.14.0.

@benjamn benjamn closed this Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment