Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two jquery versions in meteor initial bundle #10289

Open
ignl opened this issue Oct 19, 2018 · 4 comments
Assignees

Comments

@ignl
Copy link

@ignl ignl commented Oct 19, 2018

Meteor 1.8

Create simple-todos app.
Run meteor npm install --save jquery
Start an app with bundle visualizer

Expected:
From what I understand meteor will only use npm jquery version and the old one won't be used and should not be loaded in the bundle

Result:
There are two versions of jquery in the bundle

@arggh

This comment has been minimized.

Copy link
Contributor

@arggh arggh commented Mar 9, 2019

Just noticed the same while trying to reduce the size of our app bundle. I was also in belief that only the npm-originated version would be included, if available.

@arggh

This comment has been minimized.

Copy link
Contributor

@arggh arggh commented Mar 9, 2019

I even made a repro to make sure it wasn't anything funky with our app, but no it wasn't: https://github.com/arggh/meteor-jquery-issue

How the repro was made

  1. meteor create app
  2. cd app && meteor npm install --save jquery

And here is a beautifully hand-crafted diagram visualizing the relative size that jQuery is occupying in the basic scaffolded app made with meteor create (it's about 50% or ~200kb).

starburst

@arggh arggh referenced this issue Mar 9, 2019
@arggh

This comment has been minimized.

Copy link
Contributor

@arggh arggh commented Mar 9, 2019

Relevant issues:

#6864
#6626

@benjamn benjamn added this to the Package Patches milestone Mar 19, 2019
@benjamn benjamn self-assigned this Mar 19, 2019
benjamn added a commit that referenced this issue Mar 19, 2019
Although the Meteor jquery package is no long a core package (and thus is
not tied to the Meteor release), it seems like a good idea to nudge folks
towards installing jquery from npm, instead of relying on the very old
version (1.12.1) residing in meteor/packages/non-core/jquery/jquery.js.

Closes #10289.
@afrokick

This comment has been minimized.

Copy link
Contributor

@afrokick afrokick commented Nov 5, 2019

any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.