Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A warning about "caniuse-lite" prints during minification #10682

Closed
glasser opened this issue Aug 29, 2019 · 14 comments
Closed

A warning about "caniuse-lite" prints during minification #10682

glasser opened this issue Aug 29, 2019 · 14 comments
Assignees
Labels
confirmed We want to fix or implement it good first issue Good first issue or something that should is nice to do. Project:CSS Project:Isobuild:Minifiers Severity:has-workaround

Comments

@glasser
Copy link
Contributor

glasser commented Aug 29, 2019

minifier-css depends recursively on browserslist, which you can see in its checked-in shrinkwrap file.

browserslist has this code to print a warning if its dependency caniuse-lite is more than 6 months out of date. It was last updated in Meteor in February so it is printing for all users who minify right now.

I don't even know if minifier-css takes advantage of anything provided by browserslist or caniuse-lite. I suggest it should set the $BROWSERSLIST_IGNORE_OLD_DATA environment variable to disable this warning.

@benjamn
Copy link
Contributor

benjamn commented Sep 6, 2019

Should be mitigated by c2499b1f21ef195f31652deac7443cc33b98af66, which will be released as part of Meteor 1.8.2. Disabling the warning is tempting, but I don't mind the additional incentive to keep these packages up-to-date.

@evolross
Copy link
Contributor

FWIW I'm still seeing this after updating my app to Meteor 1.9.

@repetitioestmaterstudiorum

Seeing this in Meteor 1.10.1

@linegel
Copy link

linegel commented Apr 24, 2020

Appears in Meteor 1.10.1

@filipenevola filipenevola added the good first issue Good first issue or something that should is nice to do. label May 21, 2020
@Natas0007
Copy link

Still in Meteor 1.10.2. I've disabled with the env var, but just giving a heads up.

@afrokick
Copy link
Contributor

There is PR #11075 for updating the version of PostCSS to resolve this issue.

@afrokick
Copy link
Contributor

afrokick commented Jun 3, 2020

Will be in 1.10.3 Thanks @filipenevola

@filipenevola
Copy link
Member

minifier-css@1.5.1 is published.

@iancwinter
Copy link

Still there in 1.11. :-(

@afrokick
Copy link
Contributor

afrokick commented Sep 5, 2020

Ok, i’ll update it later to use the latest version of PostCSS

@filipenevola
Copy link
Member

filipenevola commented Sep 10, 2020

Published minifier-css@1.5.3 and standard-minifier-css@1.6.1.

meteor update standard-minifier-css should fix your warning.

@iancwinter
Copy link

Hmm… I already have standard-minifier-css@1.6.0 as part of Meteor 1.11 so not sure a downgrade to 1.5.3 would fix things (and may introduce other incompatibilities). Unless minifier-css is different to standard-minifier-css.

@afrokick
Copy link
Contributor

afrokick commented Sep 11, 2020

@filipenevola so, we need to update standard-minifier-css to use the latest version of minifier-css, right?

#11170

@filipenevola
Copy link
Member

Yeah, meteor update standard-minifier-css is also necessary (1.6.1 was published).

But I believe this warning can come back again and again, then we need to always bump these versions when PostCSS releases a new version.

@meteor meteor locked as resolved and limited conversation to collaborators Sep 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
confirmed We want to fix or implement it good first issue Good first issue or something that should is nice to do. Project:CSS Project:Isobuild:Minifiers Severity:has-workaround
Projects
None yet
Development

No branches or pull requests

10 participants