New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 0.3.4 breaks event handling code #107

Closed
droot opened this Issue Apr 28, 2012 · 4 comments

Comments

Projects
None yet
4 participants
@droot

droot commented Apr 28, 2012

I upgraded to 0.3.4 today and my event handling code (specified through maps in template) is not working for some of the selectors. Basic click handlers are working, but the moment I specify any selectors, it doesn't work properly. I did not find any specific documentation for migration to 0.3.4 specific to this part. I downgraded to 0.3.3 and my app was restored.

Has anyone else also faced similar issue ? or I am missing something basic.

@dustinsmith1024

This comment has been minimized.

dustinsmith1024 commented Apr 28, 2012

Yea I noticed this too. It doesn't appear the events are bubbling up the same. Looks like you either need to be very specific on the element or just a basic event with no selector.

There was mention of a fix to the outer div issue...

@dgreensp

This comment has been minimized.

Contributor

dgreensp commented Apr 28, 2012

Sorry about this. It's a regression introduced by the event bug fixes in 0.3.4. @dustinsmith1024 is spot on, it seems to be that handlers with no selector and handlers where the target matches the selector work, but bubbling is broken. We'll have a fix out shortly.

@droot

This comment has been minimized.

droot commented Apr 28, 2012

Thanks for the update Dustin and David,

Will be waiting for the fix :)

On 28 April 2012 23:24, David Greenspan <
reply@reply.github.com

wrote:

Sorry about this. It's a regression introduced by the event bug fixes in
0.3.4. @dustinsmith1024 is spot on, it seems to be that handlers with no
selector and handlers where the target matches the selector work, but
bubbling is broken. We'll have a fix out shortly.


Reply to this email directly or view it on GitHub:
#107 (comment)

@debergalis

This comment has been minimized.

Member

debergalis commented Apr 28, 2012

fixed in 523c60d

@debergalis debergalis closed this Apr 28, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment