Zero exit value when npm dependency installation fails

[mitar]

I am using Travis CI to do tests and I noticed that if there is a failure when installing npm dependencies, meteor still exists with zero exit value so tests are seen as successful.

npm http 200 https://github.com/peerlibrary/pdf.js/tarball/d48097845fa4fb4e00fe895d0412872535ad0730

npm ERR! cb() never called!
npm ERR! not ok code 0

at ChildProcess.exithandler (child_process.js:540:15)
at ChildProcess.EventEmitter.emit (events.js:99:17)
at maybeClose (child_process.js:638:16)
at Process._handle.onexit (child_process.js:680:5)

Please fix the problem and restart.
The command "make test" exited with 0.
Done. Your build exited with 0.

(The issue why it fails is because tarball is 7.9 MB. But I will open another ticket for that. To increase the timeline.)

[glasser]

This code has been rewritten in 0.6.5, but the issue might still exist. If you see it again, can you report including the actual meteor command that is run (by Travis)?

[mitar]

It happened again on Travis with 0.6.5. Here is complete log with all commands being run, which is simply doing tests with this code.

I think the issue is simply that this npm tar is huge and there is some timeout issue.

[glasser]

OK, so the underlying npm error occurred in that log, but that's something we're tracking separately in #1190.

This bug is about failing to exit 0 when npm fails, and your log doesn't show that: it shows meteor noticing the issue and getting stuck in a "Waiting for file change". (I suggest that Arunoda change his test driver scripts to pass --once to meteor test-packages...)

So I will close this for now.