New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submit events map does not work on IE8 #1191

Closed
piffie opened this Issue Jun 28, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@piffie

piffie commented Jun 28, 2013

I just díscovered that using submit event maps on IE8 does not work.
The result is a complete fail of the loading of the Template.

I traced it down to

https://github.com/meteor/meteor/blob/master/packages/universal-events/events-ie.js?source=cc#L92

props.push(node, 'ondatasetcomplete');

in the line afterwards, you set properties of an object. in the case of submit, you set the propertyname to the object. And that does not work.

@n1mmy

This comment has been minimized.

Member

n1mmy commented Jun 28, 2013

@piffle Can you please submit a reproduction in the form of a github repo with a meteor app that demos the problem (see https://github.com/meteor/meteor/blob/master/Contributing.md)? I think the solution is to remove the node, on the line you point at, but I want to test the fix before merging.

n1mmy added a commit that referenced this issue Jul 24, 2013

Fix submit event on old IE. Fixes #1191
Not tested, but it looks right from code inspection and looking at the history.
@n1mmy

This comment has been minimized.

Member

n1mmy commented Jul 24, 2013

Should be fixed on devel.

@n1mmy n1mmy closed this Jul 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment