New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing of Meteor exceptions through Future losses data #1482

Closed
mitar opened this Issue Oct 10, 2013 · 9 comments

Comments

Projects
None yet
4 participants
@mitar
Collaborator

mitar commented Oct 10, 2013

Passing of Meteor exceptions through Future losses data. The issue is how exceptions are cloned in Fibers.

Practically, Meteor.Error object becomes longError.__proto__ value. And the only property on longError is stack.

I am reporting this here because of Meteor's heavy dependency on Fibers.

mitar added a commit to mitar/meteor-issue1482 that referenced this issue Oct 10, 2013

@mitar

This comment has been minimized.

Collaborator

mitar commented Oct 10, 2013

I would argue as well that the way how Meteor is blindly just creating exception despite values might be missing could be done in a bit more robust way?

@mitar

This comment has been minimized.

Collaborator

mitar commented Oct 10, 2013

(I was getting "Exception while delivering result of invoking" message as well in my real app.)

@mitar

This comment has been minimized.

Collaborator

mitar commented Oct 10, 2013

Is there a way to use my own fork of fibers in meantime? It seems everything is installed from tgz?

@n1mmy

This comment has been minimized.

Member

n1mmy commented Oct 10, 2013

Issue confirmed. Thanks for the clear cloneable example, @mitar!

@skaag

This comment has been minimized.

Contributor

skaag commented Oct 10, 2013

Could this problem with Fibers be somehow related to the #1481 bug I reported?

@mitar

This comment has been minimized.

Collaborator

mitar commented Oct 10, 2013

@skaag: Very probably not.

@mitar

This comment has been minimized.

Collaborator

mitar commented Oct 10, 2013

@n1mmy: Maybe it would be useful if you can confirm the bug in laverdet/node-fibers#144 as well. Moreover, I am not sure that the fix I am proposing there is really the best one.

@mitar

This comment has been minimized.

Collaborator

mitar commented Oct 12, 2013

@glasser glasser closed this in 5a8ab31 Oct 18, 2013

@glasser

This comment has been minimized.

Member

glasser commented Oct 18, 2013

Thanks @mitar. While not the most generic thing ever, this commit addresses the specific issue involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment