New upsert fails with $push and $each

[mcbain]

Collection.update works as expected, but new upsert not. It
simply pushes the whole element {"$each":["A","B","C"],"$slice":-3} to the elements array.

Tinytest.add("upsert - update handles $push with $each correctly", function (test) {
    var collection = new Meteor.Collection(Random.id());

    var id = collection.insert({name: 'jens'});

    var result = collection.update(id,
        {
            $push: {
                elements: {
                    $each: ['A', 'B', 'C'],
                    $slice: -3
                }}});

    test.equal(collection.findOne(id),
        {
            _id: id,
            name: 'jens',
            elements: ['A', 'B', 'C']
        }
    );
});

Tinytest.add("upsert - handles $push with $each correctly if doc not exists", function (test) {
    var collection = new Meteor.Collection(Random.id());

    var result = collection.upsert(
        {name: 'jens'},
        {
            $push: {
                elements: {
                    $each: ['A', 'B', 'C'],
                    $slice: -3
                }}});

    test.equal(collection.findOne(result.insertedId),
        {
            _id: result.insertedId,
            name: 'jens',
            elements: ['A', 'B', 'C']
        }
    );
});

[estark37]

Hi @mcbain. This actually appears to be a limitation of minimongo's implementation of modifiers, which the upsert implementation uses in some cases.

C = new Meteor.Collection("foo", { connection: null })
C.insert({"foo:"bar"})
C.update({foo:"bar"}, {$push: {bar: {$each: [1,2]}}})
C.findOne()
> {"_id":"gxFYoooNw8QjYhPhD","foo":"bar","bar":[{"$each":[1,2]}]}

I'll look into it to see if this can be easily fixed. Thanks for the report and the clear reproduction!

[mcbain]

The real problem is that happens also at server side, where {upsert:true} worked before.

[glasser]

Good point about Meteor not implementing the new $each/$sort/$slice Mongo $push syntax! I just implemented them: 3aca36a

Thanks for writing these tests, too! I'd like to include them in Meteor, though you'll have to accept our CLA first: https://contribute.meteor.com/

[glasser]

I included your tests as well. Thanks!