/meteor

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meteor npm updater does not notice changes to shrinkwrap #1648

Closed
glasser opened this Issue Dec 3, 2013 · 0 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@glasser
@glasser
Member

glasser commented Dec 3, 2013

The logic in tools/meteor_npm.js does nothing if the top-level npm dependencies in your local tree match the dependencies declared with Npm.depends. So a commit like 0a4663b will not cause a re-install.

glasser added a commit that referenced this issue Dec 3, 2013

@glasser
Add comment referencing #1648
c066b90

glasser added a commit that referenced this issue Jan 4, 2014

@glasser
Upgrade websocket-driver to 0.3.2 
This lowers the max websocket frame length from 1GB to 64MB.

Note that due to #1648, this may not immediately affect existing
checkouts of meteor (but will get into all release builds).
4f7d14c

glasser added a commit that referenced this issue May 22, 2014

@glasser
Notice changes to npm-shrinkwrap.json 
There were two separate issues here:

 - npm-shrinkwrap.json wasn't actually being used as part of the
   watchset/buildinfo, so changes to it might not cause the package to
   be considered for rebuilding

 - meteor-npm only compared top-level changes when deciding whether to
   update, not all changes

Fixes #1648
2783686

@glasser glasser closed this in bceab2c Jun 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment