meteor npm updater does not notice changes to shrinkwrap #1648
Comments
glasser
added a commit
that referenced
this issue
Jan 4, 2014
This lowers the max websocket frame length from 1GB to 64MB. Note that due to #1648, this may not immediately affect existing checkouts of meteor (but will get into all release builds).
glasser
added a commit
that referenced
this issue
May 22, 2014
There were two separate issues here: - npm-shrinkwrap.json wasn't actually being used as part of the watchset/buildinfo, so changes to it might not cause the package to be considered for rebuilding - meteor-npm only compared top-level changes when deciding whether to update, not all changes Fixes #1648
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The logic in
tools/meteor_npm.js
does nothing if the top-level npm dependencies in your local tree match the dependencies declared withNpm.depends
. So a commit like 0a4663b will not cause a re-install.The text was updated successfully, but these errors were encountered: