Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findAll on template instances should return arrays, not jQuery objects #2039

Closed
avital opened this issue Apr 9, 2014 · 2 comments
Closed
Labels
confirmed We want to fix or implement it

Comments

@avital
Copy link
Contributor

avital commented Apr 9, 2014

Currently, this.findAll is just an alias for this.$, which returns jQuery objects that almost look like arrays, but not in all cases. Instead, this.findAll should return an array as before, and this.$ should still return jQuery objects.

We'd accept a good pull request implementing this. An acceptable pull request must contain tests. See the spacebars-tests package for examples.

@subhog
Copy link
Contributor

subhog commented May 10, 2014

PR sent, see #2137

@avital
Copy link
Contributor Author

avital commented May 30, 2014

Thanks @subhog, I merged #2137

@avital avital closed this as completed May 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed We want to fix or implement it
Projects
None yet
Development

No branches or pull requests

2 participants