Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG?] EJSON addType callback not in a fiber #2136

Closed
Torsten85 opened this issue May 10, 2014 · 1 comment
Closed

[BUG?] EJSON addType callback not in a fiber #2136

Torsten85 opened this issue May 10, 2014 · 1 comment

Comments

@Torsten85
Copy link

Hey,
the constructor function of custom EJSON types are not inside a fiber. Is this intentionally or a bug?

Here is a very basic reproduction repo:
https://github.com/Torsten85/meteor-ejson-bug

Thanks
Torsten

@glasser
Copy link
Contributor

glasser commented May 15, 2014

Thanks for the reproduction. In the future, though, the idea is that your reproduction should be a full Meteor app (with .meteor directory, etc), not a single file.

There are two separate issues here:

(1) check should work outside of a Fiber. I'll look into that.

(2) Actually, it should be illegal to yield inside a EJSON converter; we should make sure that it is consistently an error to yield (although the issue right here isn't yielding).

glasser added a commit that referenced this issue May 21, 2014
Code ought to be able to parse and stringify EJSON values without having
to worry about concurrency issues.

Related to #2136.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants