New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter is hard-coded in OAuth1 #2154

Closed
ErikDakoda opened this Issue May 17, 2014 · 6 comments

Comments

Projects
None yet
3 participants
@ErikDakoda

ErikDakoda commented May 17, 2014

I have written an OAuth client for Fitbit, which was broken by Meteor 0.8.1. If your project does not use twitter, you will receive a "Service not configured" error when trying to connect to an OAuth server like Fitbit.

I have traced the error to line 14/15 in meteor/packages/oauth1/oauth1_server.js:
var callbackUrl = Meteor.absoluteUrl("_oauth/twitter?close&state=" +
query.state);

This issue is resolved when line 14/15 are changed to:
var callbackUrl = Meteor.absoluteUrl("_oauth/" + service.serviceName +
"?close&state=" + query.state);

@estark37 estark37 closed this in e86578e May 17, 2014

@estark37

This comment has been minimized.

Contributor

estark37 commented May 17, 2014

Thanks for tracking this down, @InfloErik. I fixed it on devel.

@axwaxw

This comment has been minimized.

axwaxw commented May 20, 2014

Yep just caught this too - after many hours debugging an accounts package for Xero.com...

When will this be released?

estark37 pushed a commit that referenced this issue May 21, 2014

@estark37

This comment has been minimized.

Contributor

estark37 commented May 21, 2014

We'll get it out in a patch release very soon (in the next few days).

@estark37

This comment has been minimized.

Contributor

estark37 commented May 22, 2014

@InfloErik and @axwaxw, can one of you verify that 0.8.1.3-rc2 fixes the problem? You can run your app with it by running
meteor --release 0.8.1.3-rc2
Thanks!

@axwaxw

This comment has been minimized.

axwaxw commented May 25, 2014

Hi,

Sorry for the delay - yes this is working now and I have published a package for xero that is now working: https://github.com/axwaxw/accounts-xero

Thanks!

@ErikDakoda

This comment has been minimized.

ErikDakoda commented May 27, 2014

Sorry, about the delay. Yes, 0.8.1.3 has resolved the issue. Thank you for
all of your great work! I love Meteor!

On Thu, May 22, 2014 at 12:00 AM, Emily Stark notifications@github.comwrote:

@InfloErik https://github.com/InfloErik and @axwaxwhttps://github.com/axwaxw,
can one of you verify that 0.8.1.3-rc2 fixes the problem? You can run your
app with it by running
meteor --release 0.8.1.3-rc2
Thanks!


Reply to this email directly or view it on GitHubhttps://github.com//issues/2154#issuecomment-43846448
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment