New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional callback to Accounts.loginWithPassword is no more optional #2255

Closed
splendido opened this Issue Jun 24, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@splendido

splendido commented Jun 24, 2014

Hi there!

If I'm not wrong, commit b567046 hampered the possibility to call Accounts.loginWithPassword without callback option.
See lines

and

I'm not making a pull request since this can be easily fixed in various way, among which, e.g., putting callback && callback(). But it might depends on personal taste...

btw, awesome work!

splendido added a commit to meteor-useraccounts/core that referenced this issue Jun 24, 2014

@estark37 estark37 closed this in 93483d1 Jun 27, 2014

@estark37

This comment has been minimized.

Contributor

estark37 commented Jun 27, 2014

Thanks @splendido! Fixed on devel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment