New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow login_hint to be passed for Google OAuth2 #2422

Closed
bradvogel opened this Issue Aug 21, 2014 · 5 comments

Comments

Projects
None yet
2 participants
@bradvogel
Contributor

bradvogel commented Aug 21, 2014

See the login_hint option in https://developers.google.com/accounts/docs/OAuth2Login. I need this option because my app already knows who the user should be logged in as and this will be a convenience for the user. I'd like Meteor.loginWithGoogle supported passing this in, e.g.

Meteor.loginWithGoogle({
    requestPermissions: ...
    loginHint: <what my app would like to authenticate the user as>
});

Let me know if this looks OK and I can file a PR. Thanks!

@bradvogel

This comment has been minimized.

Contributor

bradvogel commented Aug 29, 2014

Ping on this. I'll file a PR if it looks OK.

@estark37

This comment has been minimized.

Contributor

estark37 commented Aug 29, 2014

I would look at a PR for this. For maximum appeal, I'd suggest that you unify this with the existing userEmail option, which is used for Meteor developer accounts. Perhaps there could be a single options called loginHint, which can be the user's email address and is documented as working with Meteor developer accounts and Google only. (Though of course we should maintain backwards compatibility with the existing userEmail option.) Does that make sense? Thanks!

@estark37

This comment has been minimized.

Contributor

estark37 commented Oct 2, 2014

Closing this issue since it's a feature request; feel free to submit a PR.

@estark37 estark37 closed this Oct 2, 2014

bradvogel pushed a commit to bradvogel/meteor that referenced this issue Oct 9, 2014

bradvogel pushed a commit to bradvogel/meteor that referenced this issue Oct 9, 2014

@bradvogel

This comment has been minimized.

Contributor

bradvogel commented Oct 9, 2014

Filed #2790. Thanks!

@bradvogel

This comment has been minimized.

Contributor

bradvogel commented Sep 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment