publishing a package fails if a resource handler modifies files #2488
Comments
|
Yes, please do show a minimal test package, or at the very least a step by step guide to reproducing with your maximal package (clone, check out this commit, run these commands, etc). https://github.com/meteor/meteor/wiki/Contributing-to-Meteor#reporting-a-bug-in-meteor Thanks! |
|
I experienced this as well, glad someone else is reporting it. You can reproduce this by adding (locally installing) https://github.com/mizzao/meteor-jqueryui to an app, and verifying that it works. Then, try and publish it, and you will get the same error. I currently use the package as a submodule, which skips the publication process: https://github.com/mizzao/CrisisMapping. This package uses You will need to jump through the hoops as indicated in #2392 in order to do the publish, though. As I mentioned in #2506, the build system seems to be getting confused by raw files and built files. In cases where files are generated as part of the build, it isn't looking in the right place for them. |
|
Thanks, fixed. Should get this into 0.9.2 if not 0.9.1. |
Fixes #2488. Assets added via "no handler" already have their source files added to `sources` via the `sources.push(relPath)` in the sourceItems loop, and assets added via a handler should not appear as source files themselves --- the file that triggered the handler should! This fixes packages like `mizzao:build-fetcher` which add static assets via a plugin.
|
OK, 0.9.1 is pretty tied down, so it'll go in 0.9.2. Before then, feel free to run your publish command from git or something (or if you really want I can publish a release that fixes just this). This bug only affects publish. |
|
Yep, that's what I will do. Thanks for the quick fix. |
|
@glasser I'd like to re-publish, but looks like the commit with that fix just hangs when trying to publish: Can't EDIT: It published successfully after forcibly killing the shell and re-running. So this bug is fixed, although there might be another one which is probably unimportant. |
Still awaiting a proper version for publication pending the discussion in meteor/meteor#2443.
|
Not surprised if you saw a slow sync tonight; I moved all the package URLs to CloudFront CDN which basically meant that the whole metadata file needed to be resynced (our current sync protocol is pretty simplistic). Surprised that ctrl-c didn't work though. |
I build an i18n package which uses a resource-handler to make json out of yml files. This works great, however I included some yml files for tests. When I now try to publish a new version, the bundler tries to publish the json file, not the yml file.
Here is the console output:
If my package is a too big as an example, I could create a minimal test package later.
However: my guess is that the bundler can't handle if the resource-handler changes the name of the file later, can that be?
The text was updated successfully, but these errors were encountered: