New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

character set not specified in markup #264

Closed
kennethkoontz opened this Issue Aug 8, 2012 · 5 comments

Comments

Projects
None yet
6 participants
@kennethkoontz

kennethkoontz commented Aug 8, 2012

Firebug and Chrome Developer tools are complaining about the character encoding.

Firebug:

The character encoding of the HTML document was not declared. The document will render with garbled text in some browser > > configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must > > to be declared in the document or in the transfer protocol.

I would expect meteor to specify this.

<meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> 
@jaeh

This comment has been minimized.

jaeh commented Aug 16, 2012

if you add this meta tag to the head of your app firefox will still complain about the content-type declaration not being in the first 1024 bytes of the file, which means that either {{{head_extra}} has to be moved up in app.html.in in the meteor core or that meteor should send out the encoding as a http head parameter.

@glasser

This comment has been minimized.

Member

glasser commented Sep 7, 2012

If we're going to be specifying Content-Type, I assume we'd just do it in the HTTP header (in server.js) rather than by using META. Currently we specify just "text/html".

Is it safe to assume that, hey, it's 2012, everyone should be using UTF8?

@ghost ghost assigned glasser Sep 7, 2012

@kinjal

This comment has been minimized.

kinjal commented Sep 8, 2012

Like we have a choice:) We dont say no to a client just because he is not wearing pants!

I think something like a config.js file in the application folder (/var/www/site, not /usr/lib/meteor) or a Meteor.config event (like Meteor.startup) should be considered as a way to allow overriding defaults. Besides the charset, this could also include database connection properties, other headers, aliases for legacy support and so forth.

@pierredewilde

This comment has been minimized.

pierredewilde commented Sep 8, 2012

+1 for config

@n1mmy n1mmy closed this in 65aaa2e Sep 25, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment