Skip to content

It doesn't make sense for compileStep.addJavaScript to use the bare option from the parent file #2834

@mizzao

Description

@mizzao

This was changed in commit cf68cd7

In packages such as https://github.com/mizzao/meteor-build-fetcher and https://github.com/Nemo64/meteor-translator, .json. and .yml files are used to generate javascript respectively, and should be able to decide if a file is going to be added bare or not during the build process. Whether the parent file is bare or not should have no bearing on this, except as a possible input to be provided.

Packages that try to add bare files in the build process just get ignored now.

I don't think this change was thought through particularly, as

if (options.bare && ! archinfo.matches(inputSourceArch.arch, "web"))
still checks for options.bare while fileOptions.bare is used later on.

@stubailo, your thoughts please?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions