New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It doesn't make sense for compileStep.addJavaScript to use the bare option from the parent file #2834

Closed
mizzao opened this Issue Oct 17, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@mizzao
Contributor

mizzao commented Oct 17, 2014

This was changed in commit cf68cd7

In packages such as https://github.com/mizzao/meteor-build-fetcher and https://github.com/Nemo64/meteor-translator, .json. and .yml files are used to generate javascript respectively, and should be able to decide if a file is going to be added bare or not during the build process. Whether the parent file is bare or not should have no bearing on this, except as a possible input to be provided.

Packages that try to add bare files in the build process just get ignored now.

I don't think this change was thought through particularly, as

if (options.bare && ! archinfo.matches(inputSourceArch.arch, "web"))
still checks for options.bare while fileOptions.bare is used later on.

@stubailo, your thoughts please?

@mizzao

This comment has been minimized.

Contributor

mizzao commented Oct 17, 2014

#2835 is a proposed solution for this which seems like it should work for all cases.

@glasser

This comment has been minimized.

Member

glasser commented Oct 21, 2014

This is fixed on devel in 627674e.

@glasser glasser closed this Oct 21, 2014

@mizzao

This comment has been minimized.

Contributor

mizzao commented Oct 21, 2014

Thank you!

mizzao added a commit to mizzao/meteor-openlayers that referenced this issue Oct 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment