Skip to content

Crash instead of error when two packages define plugins for the same extension #3015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matteodem opened this issue Nov 4, 2014 · 3 comments
Closed

Crash instead of error when two packages define plugins for the same extension #3015

matteodem opened this issue Nov 4, 2014 · 3 comments
Milestone
Tool Performance ...

Comments

@matteodem
Copy link
Contributor 

=> Started proxy.
=> Started MongoDB.
compile-cssShrink: updating npm dependencies -- cssshrink...

/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/dev_bundle/lib/node_modules/fibers/future.js:173
                        throw(ex);
                              ^
TypeError: Cannot read property 'name' of undefined
    at /Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/compiler.js:384:34
    at Function._.each._.forEach (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/dev_bundle/lib/node_modules/underscore/underscore.js:87:22)
    at /Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/compiler.js:377:7
    at Array.forEach (native)
    at Function._.each._.forEach (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/dev_bundle/lib/node_modules/underscore/underscore.js:79:11)
    at compileUnibuild (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/compiler.js:376:5)
    at /Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/compiler.js:1077:27
    at Array.forEach (native)
    at Function._.each._.forEach (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/dev_bundle/lib/node_modules/underscore/underscore.js:79:11)
    at Object.compiler.compile (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/compiler.js:1076:5)
    at /Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/catalog-local.js:733:25
    at /Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/buildmessage.js:338:18
    at _.extend.withValue (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/fiber-helpers.js:112:14)
    at /Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/buildmessage.js:331:34
    at _.extend.withValue (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/fiber-helpers.js:112:14)
    at /Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/buildmessage.js:329:23
    at _.extend.withValue (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/fiber-helpers.js:112:14)
    at Object.enterJob (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/buildmessage.js:303:26)
    at _.extend._build (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/catalog-local.js:729:20)
    at _.extend.getLoadPathForPackage (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/catalog-local.js:503:12)
    at _.extend.getLoadPathForPackage (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/catalog.js:192:30)
    at _.extend.getLoadPathForPackage (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/package-loader.js:93:25)
    at _.extend.getPackage (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/package-loader.js:55:25)
    at Object.compiler.eachUsedUnibuild (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/compiler.js:85:37)
    at compileUnibuild (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/compiler.js:337:14)
    at /Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/compiler.js:1077:27
    at Array.forEach (native)
    at Function._.each._.forEach (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/dev_bundle/lib/node_modules/underscore/underscore.js:79:11)
    at Object.compiler.compile (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/compiler.js:1076:5)
    at /Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/bundler.js:2004:26
    at /Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/buildmessage.js:250:13
    at _.extend.withValue (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/fiber-helpers.js:112:14)
    at /Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/buildmessage.js:243:29
    at _.extend.withValue (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/fiber-helpers.js:112:14)
    at /Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/buildmessage.js:241:18
    at _.extend.withValue (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/fiber-helpers.js:112:14)
    at /Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/buildmessage.js:232:23
    at _.extend.withValue (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/fiber-helpers.js:112:14)
    at Object.capture (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/buildmessage.js:231:19)
    at Object.exports.bundle (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/bundler.js:1926:31)
    at bundleApp (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/run-app.js:509:28)
    at _.extend._runOnce (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/run-app.js:527:24)
    at _.extend._fiber (/Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/run-app.js:744:28)
    at /Users/Matteo/.meteor/packages/meteor-tool/.1.0.35.7nk0j7++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/tools/run-app.js:380:12

Simply clone https://github.com/matteodem/compile-dempendency-error and run meteor to reproduce.
@matteodem
Copy link
Contributor Author

Can I get some help here?

@glasser
Copy link
Contributor

glasser commented Dec 3, 2014

This looks like a bug in printing the error message when there are multiple packages providing plugins for the same extension (which we don't currently support).

(The current build APIs don't actually let you do what you're trying to do; that's why minification is implemented directly in the tool. We should eventually make that into a real API.)

@glasser glasser added this to the Tool Performance and Stability milestone Dec 3, 2014
@glasser glasser changed the title Error when specifying npm dependency on npm package cssshrink Crash instead of error when two packages define plugins for the same extension Dec 3, 2014
@glasser glasser mentioned this issue Dec 5, 2014
Closed
@matteodem
Copy link
Contributor Author

great! thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Tool Performance and Stability
Development

No branches or pull requests
2 participants
@glasser @matteodem