New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform in allow does not work properly when defined as null in deny #3108

Closed
darkship opened this Issue Nov 17, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@darkship

darkship commented Nov 17, 2014

Hi,
In my repo https://github.com/darkship/test_allow_helpers, you will find that I defined transform : null in deny. It results that transforms aren't applyed to allow too.

aldeed/meteor-collection2#144

@darkship darkship changed the title from Transform in allow do not work properly when defined as null in deny to Transform in allow does not work properly when defined as null in deny Nov 18, 2014

@darkship

This comment has been minimized.

darkship commented Nov 27, 2014

Function Mongo.Collection.prototype._validatedUpdateLine 969 of packages/mongo/collection.js

Only the first transform is applied to the document. if (!factoriedDoc) should be removed twice.

@glasser

This comment has been minimized.

Member

glasser commented Jan 9, 2015

Agree. Would review a PR with tests to fix this.

@glasser glasser added this to the Winter 2015 Mongo Maintenance milestone Jan 21, 2015

@glasser glasser closed this in 6ef63ce Mar 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment