New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phantomjs keeps running after `meteor --test` #3205

Closed
Sanjo opened this Issue Nov 29, 2014 · 8 comments

Comments

Projects
None yet
3 participants
@Sanjo
Contributor

Sanjo commented Nov 29, 2014

There seems to be something wrong with how meteor --test exits.

Reproduce
Download https://github.com/meteor-velocity/velocity-examples/tree/master/

  1. Make sure no phantomjs processes are running
  2. Start the app with the commands below
  3. After the app has exited, there is still a phantomjs process running from the meteor --test run.

With leaderboard-mocha

cd leaderboard-mocha
meteor --test

Or with leaderboard-jasmine

cd leaderboard-jasmine
JASMINE_SINGLE_RUN=1 meteor --test
@Sanjo

This comment has been minimized.

Contributor

Sanjo commented Nov 29, 2014

There is also a related issue in sanjo:jasime: the browser that is spawned by Karma Test Runner is not closed. This is why the JASMINE_SINGLE_RUN=1 is needed as a temporary fix.

With meteor (with --test) the browser is correctly closed when the app exits.

@glasser

This comment has been minimized.

Member

glasser commented Dec 5, 2014

meteor --test is maintained by the Velocity team. Please file bug reports at https://github.com/meteor-velocity/velocity

@glasser glasser closed this Dec 5, 2014

@Sanjo

This comment has been minimized.

Contributor

Sanjo commented Dec 5, 2014

Should I just do a pull-request for fixing this and you will accept? Because the code is part of meteor core.

@glasser

This comment has been minimized.

Member

glasser commented Dec 9, 2014

Yeah, as long as it's signed off by somebody listed on the Velocity page (such as you) and it doesn't look totally wrong, I'll probably accept it!

Sanjo added a commit to meteor-velocity/meteor that referenced this issue Dec 13, 2014

Sanjo added a commit to meteor-velocity/meteor that referenced this issue Dec 13, 2014

glasser added a commit that referenced this issue Jan 12, 2015

Maxim-Filimonov added a commit to Maxim-Filimonov/meteor that referenced this issue Jan 17, 2015

@ThePenguin1140

This comment has been minimized.

ThePenguin1140 commented Jan 26, 2015

It seems that the fix for this is not included in the current version (1.0.3.1).
In which version will this fix be included?

@glasser

This comment has been minimized.

Member

glasser commented Jan 27, 2015

This got merged to devel during the release stabilization for 1.0.3(.1) so it should get into the next release. (cd014c7)

@ThePenguin1140

This comment has been minimized.

ThePenguin1140 commented Jan 27, 2015

Awesome, about how long will it take for the next version to be released?

@glasser

This comment has been minimized.

Member

glasser commented Jan 27, 2015

We don't have a specific release schedule, but we have on average put out one non-patch release per month for the past three years.

glasser added a commit that referenced this issue Feb 24, 2015

Revert "Kill PhantomJS processes after `meteor --test`"
This reverts commit cd014c7.

This was intended to be placed on devel (see #3205) and I accidentally
placed it on master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment