Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setBundledJsCssPrefix appears to brick Cordova app #3278

Closed
zol opened this issue Dec 11, 2014 · 2 comments
Closed

setBundledJsCssPrefix appears to brick Cordova app #3278

zol opened this issue Dec 11, 2014 · 2 comments

Comments

@zol
Copy link
Contributor

@zol zol commented Dec 11, 2014

Without a CDN, Hot Code Pushes to mobile work fine. When a CDN is enabled (using WebAppInternals.setBundledJsCssPrefix(Meteor.settings.public.cdn);) devices appear to receive a faulty code push and the app becomes 'bricked'. The only way to recover is by uninstalling and re-installing the app.

I've provided a screenshot of the Safari debugger connected to the running app on iOS at the point that it completes and tries to refresh. Notice it tries to load the js/css found in bundle/programs/web.cordova from the CDN (I believe this is incorrect).

screen shot 2014-12-11 at 1 29 44 pm

@tmeasday
Copy link
Contributor

@tmeasday tmeasday commented Dec 18, 2014

I've created a fix for this in #3311

tmeasday added a commit to tmeasday/meteor that referenced this issue Dec 18, 2014
Cordova serves assets directly from the device so it doesn’t make sense to hit the CDN for them. Besides it causes issues because they are served from /__cordova (on the real webserver) anyway.
Slava added a commit that referenced this issue Dec 18, 2014
Don’t apply the CDN prefix on cordova. For #3278
@Slava
Copy link
Member

@Slava Slava commented Dec 18, 2014

Merged in #3311

@Slava Slava closed this Dec 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants