New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package system defaults to ancient versions if no semver is specified? #3282
Comments
Can you provide a full cloneable reproduction? Ideally with 1.0.2-rc.1. |
I can't repro this with 1.0.2 which btw seems blazingly fast at reloading everything!! if this is the long awaited speedup code drop, there's no way i'm going back to 1.0 :) woohoo! |
@glasser I ran into the same issue when running a routine The issue for me was with I fixed the issue by removing the offending packages from Something about I can't push this to a public repo either. Cheers. |
@dgreensp Is this something you can look into, since you're working on stuff with the constraint solver anyway? The constraint solver is definitely supposed to try hard to avoid downgrading anything if possible. |
I can look into it. Thoughts off the top of my head: The constraint As always, cloneable reproductions are greatly appreciated. |
Reopening. See also https://groups.google.com/forum/#!topic/meteor-talk/dN415Rbcvg0 |
@RobertLowe, to clarify, your problem was with packages being downgraded that weren't listed in |
@dgreensp Yes, I believe that's the case, I'm mobile right now so if memory serves that is correct. It happens when dependacies are left unspecified. Cheers |
Previously, “meteor update foo” meant “ignore .meteor/versions for foo”, which would upgrade if “foo” was a root dependency, and downgrade if foo was only a transitive dependency. Now, we make sure to try to upgrade foo even if it is not a root dependency. See #3282.
Fixed on devel. What |
Thanks @dgreensp you're awesome! |
This may be somewhat related to this issue.
None of these is a binary package. I think this is something relevant to this issue. |
Did you commit .meteor/versions? Just running the app shouldn't change the versions for no reason. |
Ah yes. it's there. |
@dgreensp OT: Is there a way to dump a dependancy's tree of dependancies? This would be fairly useful... As of right now it's a bit difficult to see what a dependancy is built on top of other then digging through atmosphere. Cheers |
@arunoda If you revert .meteor/versions and run again, does it downgrade again, reproducibly? That sounds like a bug that I'd like to reproduce. However, I suspect it is because if anything triggers a full run of the constraint solver, indirect dependencies may get downgraded. That suggests a second question. After you get the "downgraded" message, if you change only those versions back to what they were, does it downgrade again? My fix only address what happens when you run @RobertLowe You're in luck. There's no tree, but as of 1.0.3-rc.0, |
@dgreensp It's hard to reproduce. Only happens on some linux boxes only. Yes, if I updated again with meteor update it will work correctly. I try to find if it can be reproduced. Then I'll share the linux VM with you. |
I am getting this with codeship test running. When I run the app in the codeship environment, it downgrades the app from 0.3.6 to 0.3.4 (xolvio:cucumber) for some reason. Will see if I can make a quick repro of it. |
I'm getting this error when deploying to Heroku servers using the https://github.com/AdmitHub/meteor-buildpack-horse buildpack. Random packages get downgraded unless I specify an exact version for them (running |
Yes, mine turned out to be the same issue, with no semvar it seemed to just randomly downgrade. Once I pegged xolvio:cucumber@0.3.6, it worked fine on install. @glasser should we open a new issue since this one is closed? |
Is there any way we can reproduce this? I'd love to get to the bottom of it! The part that's hard to figure out is that meteor should use the versions in .meteor/versions, which should be checked into your repo. If it needs to choose different versions for some reason -- which may be possible to trigger based on architecture? I'm not sure -- it should write the new versions to .meteor/versions. So you should at least be able to see the "paper trail" in .meteor/versions, and reproduce the downgrade repeatedly by reverting it. Are you able to get the message repeatably? Thanks. |
I will see if I can get a simple repo up and repro on codeship... It has a debug console so you can ssh in and play around with the box directly... I have seen it happen 2 out of 2 times on codeship so far without cucumber being pegged to a version. |
@dgreensp I assume MiniSat should solve this? |
My understanding is that this issue and #3653 are fixed on |
if add a package with no semver specified it will default to the oldest version:
at the very least this seems wrong, it should default to the newest version?
separately, if I specify a recent version, however there is no way to say "at least 4.0" with meteor's flavor of semver. both of these:
will pull in
4.0.0
where currently that package is at4.2.0
.afaik there is no support for something like
The text was updated successfully, but these errors were encountered: