New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runner watcher fires when editing (but not saving) files in vim #3322

Closed
glasser opened this Issue Dec 19, 2014 · 0 comments

Comments

Projects
None yet
1 participant
@glasser
Member

glasser commented Dec 19, 2014

Breaking this out from #3285 (comment) because we are not blocking the release on it.

@robfallows:

I'm seeing lots of client refreshes when opening and editing css files (i.e. before saving changes). It seems to "see" the vim .name.swp file as something to track (this may have been in previous releases - I've only just noticed it).

Otherwise, the speed of refresh, particularly on server code is way better than 1.0.1 - It's taking about 1/10 the time it used to. Nice work!

@glasser:

@robfallows Can you provide more detailed instructions on how to reproduce this? Can you reproduce this in, eg, a brand new meteor created app? What file are you editing in what directory? What OS are you on? I can't reproduce this with editing (and not saving) the CSS file in the default meteor created app on OSX.
@robfallows I can reproduce this with editing files in the public directory, but that does not appear to be a regression vs 1.0.1. (In the public directory we rebuild on ANY file change except those in bundler.ignoreFiles, and I guess we don't have an ignore regexp for vim backup files. But in the normal source directories we only watch for files of known source code extensions.

So I can't reproduce the precise thing reported, but I can reproduce it in public and it's probably worth updating bundler.ignoreFiles.

@glasser glasser referenced this issue Dec 19, 2014

Closed

Release 1.0.2 #3285

9 of 13 tasks complete

@glasser glasser closed this in c42ecf4 Jan 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment