Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.2] test-packages should just ignore packages without tests and not fail #3334

Closed
mcbain opened this issue Dec 20, 2014 · 2 comments
Closed

Comments

@mcbain
Copy link

@mcbain mcbain commented Dec 20, 2014

Before 1.0.2 it was possible to test all packages by simply run:

meteor test-packages packages/*

With 1.0.2 one have to add a dummy test or to select all package with tests to prevent.

While trying to test package `packages/xxx`:
error: Package has no tests
@mcbain
Copy link
Author

@mcbain mcbain commented Dec 20, 2014

It sufficient to add empty onTest block.

 Package.onTest(function (api) {});
@glasser
Copy link
Member

@glasser glasser commented Dec 20, 2014

Yes, I think you're right.

@glasser glasser mentioned this issue Dec 20, 2014
5 of 7 tasks complete
@glasser glasser closed this in 00a7da3 Dec 21, 2014
glasser added a commit that referenced this issue Dec 22, 2014
Fixes #3334.

This was an intentional but poorly thought through change in
1.0.2 (1a9536b).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants