New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can only show one banner per release #3353

Closed
glasser opened this Issue Dec 23, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@glasser
Member

glasser commented Dec 23, 2014

banner code is buggy:

    var lastShown = new Date(row.lastShown);
    return lastShown < bannerDate;

row.lastShown is something like "2014-12-23T01:31:14.612Z" and that doesn't actually convert into Date.

@adnissen

This comment has been minimized.

Contributor

adnissen commented Dec 23, 2014

In my experimentation it did indeed convert into a proper date (Mon Dec 22 2014 20:31:14 GMT-0500 (EST)), but adding Date.parse might not be a bad idea.

@glasser

This comment has been minimized.

Member

glasser commented Dec 27, 2014

Ah, I was in a hurry when I noticed this: the bug is actually that the double quotes listed above are actually in the database, but I don't parse that correctly. @adnissen thanks for #3355 but that doesn't actually address the issue.

@glasser glasser closed this in 904325f Dec 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment